summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSeungha Yang <seungha@centricular.com>2020-10-04 02:02:16 +0900
committerTim-Philipp Müller <tim@centricular.com>2020-10-15 12:22:06 +0100
commit12112921307d698e267329a26a7368dbb6b8d5c2 (patch)
treec92c0f3078ea049b2a3d9591c0557c7f4d9951ad
parent48dc3070778b5a68d5e2692872a65b25cc28b473 (diff)
downloadgstreamer-plugins-bad-12112921307d698e267329a26a7368dbb6b8d5c2.tar.gz
h265parse: Don't enable passthrough by default
SEI messages contain various information which wouldn't be conveyed by using upstream CAPS (HDR, timecode for example). Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1694>
-rw-r--r--gst/videoparsers/gsth265parse.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/gst/videoparsers/gsth265parse.c b/gst/videoparsers/gsth265parse.c
index 0df3a89cf..1e097866d 100644
--- a/gst/videoparsers/gsth265parse.c
+++ b/gst/videoparsers/gsth265parse.c
@@ -2977,7 +2977,13 @@ gst_h265_parse_set_caps (GstBaseParse * parse, GstCaps * caps)
if (format == h265parse->format && align == h265parse->align) {
/* do not set CAPS and passthrough mode if SPS/PPS have not been parsed */
if (h265parse->have_sps && h265parse->have_pps) {
+ /* Don't enable passthrough here. This element will parse various
+ * SEI messages which would be very important/useful for downstream
+ * (HDR, timecode for example)
+ */
+#if 0
gst_base_parse_set_passthrough (parse, TRUE);
+#endif
/* we did parse codec-data and might supplement src caps */
gst_h265_parse_update_src_caps (h265parse, caps);