diff options
| author | Sebastian Dröge <sebastian@centricular.com> | 2014-05-21 08:53:03 +0200 |
|---|---|---|
| committer | Sebastian Dröge <sebastian@centricular.com> | 2014-05-21 08:53:03 +0200 |
| commit | 752b3a503e414b8cc29584f7ca0d19210806037e (patch) | |
| tree | d6307386082bfc0f609f687bf5fc7dd2a99d2b4c | |
| parent | 5edf0add57efb84ec08b95dd5e4b0cd390702177 (diff) | |
| download | gstreamer-plugins-bad-752b3a503e414b8cc29584f7ca0d19210806037e.tar.gz | |
dvb-section: Don't compare unsigned integers for >= 0
gst-dvb-section.c:93:12: error: comparison of unsigned expression >= 0 is always true
[-Werror,-Wtautological-compare]
if (hour >= 0 && hour < 24 && minute >= 0 && minute < 60 && second >= 0
~~~~ ^ ~
gst-dvb-section.c:93:40: error: comparison of unsigned expression >= 0 is always true
[-Werror,-Wtautological-compare]
if (hour >= 0 && hour < 24 && minute >= 0 && minute < 60 && second >= 0
~~~~~~ ^ ~
gst-dvb-section.c:93:70: error: comparison of unsigned expression >= 0 is always true
[-Werror,-Wtautological-compare]
if (hour >= 0 && hour < 24 && minute >= 0 && minute < 60 && second >= 0
~~~~~~ ^ ~
| -rw-r--r-- | gst-libs/gst/mpegts/gst-dvb-section.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/gst-libs/gst/mpegts/gst-dvb-section.c b/gst-libs/gst/mpegts/gst-dvb-section.c index add657542..dc667733b 100644 --- a/gst-libs/gst/mpegts/gst-dvb-section.c +++ b/gst-libs/gst/mpegts/gst-dvb-section.c @@ -90,8 +90,7 @@ _parse_utc_time (guint8 * data) second = ((utc_ptr[2] & 0x70) >> 4) * 10 + (utc_ptr[2] & 0x0F); /* Time is UTC */ - if (hour >= 0 && hour < 24 && minute >= 0 && minute < 60 && second >= 0 - && second < 60) { + if (hour < 24 && minute < 60 && second < 60) { return gst_date_time_new (0.0, year, month, day, hour, minute, (gdouble) second); } else if (utc_ptr[0] == 0xFF && utc_ptr[1] == 0xFF && utc_ptr[2] == 0xFF) { |