diff options
| author | Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> | 2015-09-09 11:05:35 +0100 |
|---|---|---|
| committer | Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> | 2015-09-16 09:44:19 +0100 |
| commit | 23ea8ccb43b0cca96275545ad5cfc22305d1705d (patch) | |
| tree | a05c3fabcc3ad211015956b2b27920c1bf1a30b3 | |
| parent | 7ae0dd236130a8ee84f025c0cdf19a4bedf767bb (diff) | |
| download | gstreamer-plugins-bad-23ea8ccb43b0cca96275545ad5cfc22305d1705d.tar.gz | |
mdpparser: catch failures to parse
https://bugzilla.gnome.org/show_bug.cgi?id=752480
| -rw-r--r-- | ext/dash/gstmpdparser.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/ext/dash/gstmpdparser.c b/ext/dash/gstmpdparser.c index da80aa22b..72992fabc 100644 --- a/ext/dash/gstmpdparser.c +++ b/ext/dash/gstmpdparser.c @@ -294,7 +294,7 @@ gst_mpdparser_get_xml_prop_unsigned_integer (xmlNode * a_node, *property_value = default_val; prop_string = xmlGetProp (a_node, (const xmlChar *) property_name); if (prop_string) { - if (sscanf ((gchar *) prop_string, "%u", property_value)) { + if (sscanf ((gchar *) prop_string, "%u", property_value) == 1) { exists = TRUE; GST_LOG (" - %s: %u", property_name, *property_value); } else { @@ -318,7 +318,8 @@ gst_mpdparser_get_xml_prop_unsigned_integer_64 (xmlNode * a_node, *property_value = default_val; prop_string = xmlGetProp (a_node, (const xmlChar *) property_name); if (prop_string) { - if (sscanf ((gchar *) prop_string, "%" G_GUINT64_FORMAT, property_value)) { + if (sscanf ((gchar *) prop_string, "%" G_GUINT64_FORMAT, + property_value) == 1) { exists = TRUE; GST_LOG (" - %s: %" G_GUINT64_FORMAT, property_name, *property_value); } else { @@ -351,7 +352,7 @@ gst_mpdparser_get_xml_prop_uint_vector_type (xmlNode * a_node, exists = TRUE; GST_LOG (" - %s:", property_name); for (i = 0; i < *value_size; i++) { - if (sscanf ((gchar *) str_vector[i], "%u", &prop_uint_vector[i])) { + if (sscanf ((gchar *) str_vector[i], "%u", &prop_uint_vector[i]) == 1) { GST_LOG (" %u", prop_uint_vector[i]); } else { GST_WARNING @@ -382,7 +383,7 @@ gst_mpdparser_get_xml_prop_double (xmlNode * a_node, prop_string = xmlGetProp (a_node, (const xmlChar *) property_name); if (prop_string) { - if (sscanf ((gchar *) prop_string, "%lf", property_value)) { + if (sscanf ((gchar *) prop_string, "%lf", property_value) == 1) { exists = TRUE; GST_LOG (" - %s: %lf", property_name, *property_value); } else { @@ -464,7 +465,7 @@ gst_mpdparser_get_xml_prop_SAP_type (xmlNode * a_node, prop_string = xmlGetProp (a_node, (const xmlChar *) property_name); if (prop_string) { - if (sscanf ((gchar *) prop_string, "%u", &prop_SAP_type) + if (sscanf ((gchar *) prop_string, "%u", &prop_SAP_type) == 1 && prop_SAP_type <= 6) { exists = TRUE; *property_value = (GstSAPType) prop_SAP_type; |