diff options
author | Daniel Almeida <daniel.almeida@collabora.com> | 2021-07-12 09:01:06 -0300 |
---|---|---|
committer | GStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org> | 2021-07-12 17:49:17 +0000 |
commit | d0e614b3543b0068d81e3fc6470488c227a8f270 (patch) | |
tree | 29591a8d0cdefbaeaa34b576ddb6465b8f84f0cc | |
parent | 211f968981ba6f2d33dc25b167385f971c616b21 (diff) | |
download | gstreamer-plugins-bad-d0e614b3543b0068d81e3fc6470488c227a8f270.tar.gz |
codecparsers: av1: fix underflow in last_frame_idx
The spec mandates this field be parsed using unsigned arithmetic. Nevertheless,
av1parser will use -1 apparently as an uninitialized value in
gst_av1_parse_frame_header. This immediately underflows last_frame_idx
though, since its type was defined as guint8. Fix this by converting to gint8.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2401>
-rw-r--r-- | gst-libs/gst/codecparsers/gstav1parser.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gst-libs/gst/codecparsers/gstav1parser.h b/gst-libs/gst/codecparsers/gstav1parser.h index c180ab130..45ea905e5 100644 --- a/gst-libs/gst/codecparsers/gstav1parser.h +++ b/gst-libs/gst/codecparsers/gstav1parser.h @@ -1560,7 +1560,7 @@ struct _GstAV1FrameHeaderOBU { guint32 ref_order_hint[GST_AV1_NUM_REF_FRAMES]; gboolean allow_intrabc; gboolean frame_refs_short_signaling; - guint8 last_frame_idx; + gint8 last_frame_idx; gint8 gold_frame_idx; gint8 ref_frame_idx[GST_AV1_REFS_PER_FRAME]; gboolean allow_high_precision_mv; |