diff options
| author | Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> | 2014-04-10 17:37:22 +0100 |
|---|---|---|
| committer | Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> | 2014-04-10 17:37:22 +0100 |
| commit | bbda6a1ab96005a444f83226d6fe21372812b446 (patch) | |
| tree | 784f764eb7c0b5c464b034a0f014e578dfe8d075 /ext/curl | |
| parent | feede7ddfade53dd7d22cc4068c0d45ac49961b6 (diff) | |
| download | gstreamer-plugins-bad-bbda6a1ab96005a444f83226d6fe21372812b446.tar.gz | |
curl: remove unneeded NULL check
We just checked for NULL and allocated if it was. And glib aborts
if it can't allocate, I'm told.
Coverity 1139841
Diffstat (limited to 'ext/curl')
| -rw-r--r-- | ext/curl/gstcurlsmtpsink.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/ext/curl/gstcurlsmtpsink.c b/ext/curl/gstcurlsmtpsink.c index 447068409..c2948de06 100644 --- a/ext/curl/gstcurlsmtpsink.c +++ b/ext/curl/gstcurlsmtpsink.c @@ -564,12 +564,10 @@ gst_curl_smtp_sink_set_payload_headers_unlocked (GstCurlBaseSink * bcsink) sink->base64_chunk->save = 0; if (G_UNLIKELY (!append_headers)) { - if (sink->base64_chunk != NULL) { - g_byte_array_free (sink->base64_chunk->chunk_array, TRUE); - sink->base64_chunk->chunk_array = NULL; - g_free (sink->base64_chunk); - sink->base64_chunk = NULL; - } + g_byte_array_free (sink->base64_chunk->chunk_array, TRUE); + sink->base64_chunk->chunk_array = NULL; + g_free (sink->base64_chunk); + sink->base64_chunk = NULL; return FALSE; } |