summaryrefslogtreecommitdiff
path: root/ext/ladspa
diff options
context:
space:
mode:
authorStefan Kost <ensonic@users.sourceforge.net>2008-03-20 15:54:23 +0000
committerStefan Kost <ensonic@users.sourceforge.net>2008-03-20 15:54:23 +0000
commit6ad41986af602c84943ce3aa5fa373047dcd9114 (patch)
treee35be419206e6615d23059be779252526953609c /ext/ladspa
parent7a1019a2b310cd9f91fdcb14c662291d707d1820 (diff)
downloadgstreamer-plugins-bad-6ad41986af602c84943ce3aa5fa373047dcd9114.tar.gz
ext/ladspa/: Add some thoughts and FIXME's.
Original commit message from CVS: * ext/ladspa/gstladspa.c: * ext/ladspa/gstsignalprocessor.c: Add some thoughts and FIXME's.
Diffstat (limited to 'ext/ladspa')
-rw-r--r--ext/ladspa/gstladspa.c9
-rw-r--r--ext/ladspa/gstsignalprocessor.c4
2 files changed, 12 insertions, 1 deletions
diff --git a/ext/ladspa/gstladspa.c b/ext/ladspa/gstladspa.c
index 469c64ebb..54e3eaf36 100644
--- a/ext/ladspa/gstladspa.c
+++ b/ext/ladspa/gstladspa.c
@@ -89,7 +89,16 @@ gst_ladspa_base_init (gpointer g_class)
if (LADSPA_IS_PORT_AUDIO (p)) {
gchar *name = g_strdup ((gchar *) desc->PortNames[j]);
+ /* FIXME: group stereo pairs into a stereo pad
+ * ladspa-fx have "XXX (Left)" and "XXX (Right)"
+ * where XXX={In,Input,Out,Output}
+ */
+
GST_DEBUG ("LADSPA port name: \"%s\"", name);
+ /* replaces all spaces with underscores, and then remaining special chars
+ * with '-'
+ * FIXME: why, pads can have any name
+ */
g_strdelimit (name, " ", '_');
g_strcanon (name, G_CSET_A_2_Z G_CSET_a_2_z G_CSET_DIGITS "_-><=", '-');
GST_DEBUG ("GStreamer pad name: \"%s\"", name);
diff --git a/ext/ladspa/gstsignalprocessor.c b/ext/ladspa/gstsignalprocessor.c
index 364f4fece..9cc5af246 100644
--- a/ext/ladspa/gstsignalprocessor.c
+++ b/ext/ladspa/gstsignalprocessor.c
@@ -35,7 +35,7 @@
GST_DEBUG_CATEGORY_STATIC (gst_signal_processor_debug);
#define GST_CAT_DEFAULT gst_signal_processor_debug
-
+/* FIXME: this is mono only */
static GstStaticCaps template_caps =
GST_STATIC_CAPS (GST_AUDIO_FLOAT_STANDARD_PAD_TEMPLATE_CAPS);
@@ -71,6 +71,8 @@ gst_signal_processor_pad_template_get_type (void)
return type;
}
+/* FIXME: better allow the caller to pass on the template, right now this can
+ * only create mono pads */
void
gst_signal_processor_class_add_pad_template (GstSignalProcessorClass * klass,
const gchar * name, GstPadDirection direction, guint index)