diff options
| author | Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> | 2014-04-09 17:37:41 +0100 |
|---|---|---|
| committer | Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> | 2014-04-09 17:53:57 +0100 |
| commit | 956be9a0182560459a49aab23870adb4395e11d1 (patch) | |
| tree | 00eb6d1a57f5f67275e640231b350a7ed6a68fc7 /ext/schroedinger | |
| parent | 88879654dfb19e2dd59abe201cf794a49a27e91d (diff) | |
| download | gstreamer-plugins-bad-956be9a0182560459a49aab23870adb4395e11d1.tar.gz | |
schrodec: remove unnecessary check
The tag was dereferenced earier. From the libschroedinger code,
it's not obvious to see whether tag and frame would be NULL at
the same time. I think is likely that both will be non NULL
here, but that's not certain. Additional tests may be needed
to avoid dereferencing tag and/or frame, but what to do if
only one is NULL isn't obvious, as the _get_tag function does
transfer ownership so isn't undoable.
Coverity 1139850
Diffstat (limited to 'ext/schroedinger')
| -rw-r--r-- | ext/schroedinger/gstschrodec.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/ext/schroedinger/gstschrodec.c b/ext/schroedinger/gstschrodec.c index 72f293dd2..00f442eb5 100644 --- a/ext/schroedinger/gstschrodec.c +++ b/ext/schroedinger/gstschrodec.c @@ -498,8 +498,7 @@ gst_schro_dec_process (GstSchroDec * schro_dec, gboolean eos) schro_frame_unref (schro_frame); } - if (tag) - schro_tag_free (tag); + schro_tag_free (tag); if (!eos) { go = FALSE; } |