summaryrefslogtreecommitdiff
path: root/gst-libs/gst/video
diff options
context:
space:
mode:
authorNirbheek Chauhan <nirbheek@centricular.com>2015-03-24 19:05:00 +0530
committerSebastian Dröge <sebastian@centricular.com>2015-03-24 14:54:33 +0100
commitdceb8aefd10b386535f2823af973c837d05370d5 (patch)
tree8e54e1743c64497f671d4dc2210e349951076493 /gst-libs/gst/video
parent802a29eb480e50efea381d43920aa7d91f870eea (diff)
downloadgstreamer-plugins-bad-dceb8aefd10b386535f2823af973c837d05370d5.tar.gz
videoaggregator: Document why buffer_vinfo is needed
Diffstat (limited to 'gst-libs/gst/video')
-rw-r--r--gst-libs/gst/video/gstvideoaggregatorpad.h6
1 files changed, 6 insertions, 0 deletions
diff --git a/gst-libs/gst/video/gstvideoaggregatorpad.h b/gst-libs/gst/video/gstvideoaggregatorpad.h
index 8fd061b8a..183974026 100644
--- a/gst-libs/gst/video/gstvideoaggregatorpad.h
+++ b/gst-libs/gst/video/gstvideoaggregatorpad.h
@@ -61,6 +61,12 @@ struct _GstVideoAggregatorPad
GstVideoInfo info;
GstBuffer *buffer;
+ /* The caps on the pad may not match the buffer above because of two reasons:
+ * 1) When caps change, the info above will get updated, but the buffer might
+ * not since it might be pending on the GstAggregatorPad
+ * 2) We might reject the new buffer in fill_queues() and reuse a previous
+ * buffer which has older GstVideoInfo
+ * Hence, we need to maintain a GstVideoInfo for mapping buffers separately */
GstVideoInfo buffer_vinfo;
GstVideoFrame *aggregated_frame;