diff options
| author | Nirbheek Chauhan <nirbheek@centricular.com> | 2020-08-01 02:12:21 +0530 |
|---|---|---|
| committer | Nirbheek Chauhan <nirbheek@centricular.com> | 2020-08-03 18:12:50 +0000 |
| commit | 827afa206d8c9675f2a7af402396552c2ed1df09 (patch) | |
| tree | 2dde087116c742fdf925ee6c13ab2d524666d55a /gst | |
| parent | 962ebebe066169592837af1227234e23191f286b (diff) | |
| download | gstreamer-plugins-bad-827afa206d8c9675f2a7af402396552c2ed1df09.tar.gz | |
webrtc, rtmp2: Fix parsing of userinfo in URI strings
While parsing the string, `gst_uri_from_string()` also unescapes the
userinfo. This is bad if your username contains a `:` character, since
we will then split the userinfo at the wrong location when parsing it.
To fix this, we can use the new `gst_uri_from_string_escaped()` API
that was added in
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/583
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/831
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1481>
Diffstat (limited to 'gst')
| -rw-r--r-- | gst/rtmp2/gstrtmp2locationhandler.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gst/rtmp2/gstrtmp2locationhandler.c b/gst/rtmp2/gstrtmp2locationhandler.c index 49c83bd0a..7c79c79d6 100644 --- a/gst/rtmp2/gstrtmp2locationhandler.c +++ b/gst/rtmp2/gstrtmp2locationhandler.c @@ -165,7 +165,7 @@ uri_handler_set_uri (GstURIHandler * handler, const gchar * string, { gchar *string_without_path = g_strndup (string, path_sep - string); - uri = gst_uri_from_string (string_without_path); + uri = gst_uri_from_string_escaped (string_without_path); g_free (string_without_path); } |