summaryrefslogtreecommitdiff
path: root/gst
diff options
context:
space:
mode:
authorNicolas Dufresne <nicolas.dufresne@collabora.com>2021-05-14 14:05:59 -0400
committerNicolas Dufresne <nicolas.dufresne@collabora.com>2021-05-14 14:11:39 -0400
commit0484d658a8d2793ef0b6d11cb597aac16deba3f0 (patch)
treeabfeecc78879970babec052db3579fa4f5f85485 /gst
parent35775f1aec4a5c61f275c1d6a7059f932a404d9e (diff)
downloadgstreamer-plugins-bad-0484d658a8d2793ef0b6d11cb597aac16deba3f0.tar.gz
codecalphademux: Do not set a GstFlowReturn from a boolean
This was a small overlook, gst_pad_send_event() returns a boolean, so setting it into ret could confuse the flow combiner. Though, it didn't bug, since both 0 and 1 are success (though 1 being undefined). Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2247>
Diffstat (limited to 'gst')
-rw-r--r--gst/codecalpha/gstcodecalphademux.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/gst/codecalpha/gstcodecalphademux.c b/gst/codecalpha/gstcodecalphademux.c
index 8a79bfbb0..6163a3b46 100644
--- a/gst/codecalpha/gstcodecalphademux.c
+++ b/gst/codecalpha/gstcodecalphademux.c
@@ -116,8 +116,8 @@ gst_codec_alpha_demux_chain (GstPad * pad, GstObject * object,
if (alpha_buffer) {
ret = gst_pad_push (self->alpha_pad, alpha_buffer);
} else {
- ret = gst_pad_push_event (self->alpha_pad,
- gst_event_new_gap (pts, duration));
+ gst_pad_push_event (self->alpha_pad, gst_event_new_gap (pts, duration));
+ ret = GST_PAD_LAST_FLOW_RETURN (self->alpha_pad);
}
ret = gst_flow_combiner_update_flow (self->flow_combiner, ret);