diff options
| author | Stefan Kost <ensonic@users.sf.net> | 2010-05-07 22:53:17 +0300 |
|---|---|---|
| committer | Stefan Kost <ensonic@users.sf.net> | 2010-05-07 22:53:17 +0300 |
| commit | 418a79186882e36a3b162d1bd53d98f6a0121467 (patch) | |
| tree | bad172c7efd0b223a29c879907b85db0bb0a90e6 /gst | |
| parent | 20a8666388dd56254ecae5eb232c2f24a1d7a1e1 (diff) | |
| download | gstreamer-plugins-bad-418a79186882e36a3b162d1bd53d98f6a0121467.tar.gz | |
jpegformat: make the intention of the elements more clear
Diffstat (limited to 'gst')
| -rw-r--r-- | gst/jpegformat/gstjifmux.c | 4 | ||||
| -rw-r--r-- | gst/jpegformat/gstjpegparse.c | 8 |
2 files changed, 9 insertions, 3 deletions
diff --git a/gst/jpegformat/gstjifmux.c b/gst/jpegformat/gstjifmux.c index 4fc6b7190..15e26f995 100644 --- a/gst/jpegformat/gstjifmux.c +++ b/gst/jpegformat/gstjifmux.c @@ -24,7 +24,9 @@ * SECTION:element-jifmux * @short_description: JPEG interchange format writer * - * Writes a JPEG image as JPEG/EXIF or JPEG/JFIF including various metadata. + * Writes a JPEG image as JPEG/EXIF or JPEG/JFIF including various metadata. The + * jpeg image received on the sink pad should be minimal (e.g. should not + * contain metadata already). * * <refsect2> * <title>Example launch line</title> diff --git a/gst/jpegformat/gstjpegparse.c b/gst/jpegformat/gstjpegparse.c index 3a399bd60..4217c6aff 100644 --- a/gst/jpegformat/gstjpegparse.c +++ b/gst/jpegformat/gstjpegparse.c @@ -28,7 +28,7 @@ * Parses a JPEG stream into JPEG images. It looks for EOI boundaries to * split a continuous stream into single-frame buffers. Also reads the * image header searching for image properties such as width and height - * among others. + * among others. Jpegparse can also extract metadata (e.g. xmp). * * <refsect2> * <title>Example launch line</title> @@ -39,7 +39,11 @@ * HTTP and stores it in a matroska file. * </refsect2> */ - +/* FIXME: output plain JFIF APP marker only. This provides best code reuse. + * JPEG decoders would not need to handle this part anymore. Also when remuxing + * (... ! jpegparse ! ... ! jifmux ! ...) metadata consolidation would be + * easier. + */ #ifdef HAVE_CONFIG_H #include <config.h> #endif |