diff options
author | Reynaldo H. Verdejo Pinochet <reynaldo@osg.samsung.com> | 2014-10-24 19:12:33 -0300 |
---|---|---|
committer | Reynaldo H. Verdejo Pinochet <reynaldo@osg.samsung.com> | 2014-10-24 20:24:30 -0300 |
commit | c1d48d4acdd4e261d2813c41f9aee2bc48943bd7 (patch) | |
tree | 674557428b05deec4d6e35f3ddf140939557ccb5 /sys/dvb | |
parent | ed7e763b9d527147df7701abb3c4ada4409cfe1a (diff) | |
download | gstreamer-plugins-bad-c1d48d4acdd4e261d2813c41f9aee2bc48943bd7.tar.gz |
dvbsrc: add fixme note on DTV_LNA setting
Rephrase another comment while at it
Diffstat (limited to 'sys/dvb')
-rw-r--r-- | sys/dvb/gstdvbsrc.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/sys/dvb/gstdvbsrc.c b/sys/dvb/gstdvbsrc.c index 49f3e51d8..293e3d66a 100644 --- a/sys/dvb/gstdvbsrc.c +++ b/sys/dvb/gstdvbsrc.c @@ -2316,8 +2316,8 @@ gst_dvbsrc_set_fe_params (GstDvbSrc * object, struct dtv_properties *props) /** * We are not dropping out but issuing a warning in case of wrong - * parameter combinations as this behavior should be mandated by the - * driver. Worst case scenario it will just fail at tuning. + * parameter combinations as failover behavior should be mandated + * by the driver. Worst case scenario it will just fail at tuning. */ switch (object->delsys) { @@ -2508,6 +2508,10 @@ gst_dvbsrc_set_fe_params (GstDvbSrc * object, struct dtv_properties *props) set_prop (props->props, &n, DTV_GUARD_INTERVAL, object->guard_interval); set_prop (props->props, &n, DTV_INTERLEAVING, object->interleaving); /* FIXME: Make the LNA on/off switch a property and proxy on dvbbasebin */ + /* FIXME: According to v4l advice (see libdvbv5 implementation) this + * property should be set separately as not all drivers will ignore it + * if unsupported. An alternative would be to get the dvb API contract + * revised on this regard */ set_prop (props->props, &n, DTV_LNA, LNA_AUTO); GST_INFO_OBJECT (object, "Tuning DTMB to %d Hz", freq); break; |