From 24d1e75be5d963c8c3b817e3458bb4bde31e86aa Mon Sep 17 00:00:00 2001
From: Haihao Xiang <haihao.xiang@intel.com>
Date: Tue, 29 Dec 2020 09:41:05 +0800
Subject: msdk: needn't close mfx session when failed

Otherwise we will get double free issue because mfx session is closed in
finalize. See
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1867#note_739346
for the double free issue.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1927>
---
 sys/msdk/gstmsdkcontext.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sys/msdk/gstmsdkcontext.c b/sys/msdk/gstmsdkcontext.c
index d9210780a..012efe615 100644
--- a/sys/msdk/gstmsdkcontext.c
+++ b/sys/msdk/gstmsdkcontext.c
@@ -207,7 +207,6 @@ gst_msdk_context_open (GstMsdkContext * context, gboolean hardware,
   return TRUE;
 
 failed:
-  msdk_close_session (priv->session);
   return FALSE;
 }
 
-- 
cgit v1.2.1