From 5335a36086b348d8b90c2b1da7780ecef958f6d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Wed, 24 Oct 2018 14:34:13 +0100 Subject: player: Don't set state to READY if we're already stopped Otherwise setting an URI after creation will already set the state to READY/buffering and disallow setting the configuration. See https://github.com/servo/servo/issues/22010 --- gst-libs/gst/player/gstplayer.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gst-libs/gst/player/gstplayer.c b/gst-libs/gst/player/gstplayer.c index e45c1af2d..651d2a57c 100644 --- a/gst-libs/gst/player/gstplayer.c +++ b/gst-libs/gst/player/gstplayer.c @@ -3198,6 +3198,11 @@ gst_player_pause (GstPlayer * self) static void gst_player_stop_internal (GstPlayer * self, gboolean transient) { + /* directly return if we're already stopped */ + if (self->current_state <= GST_STATE_READY && + self->target_state <= GST_STATE_READY) + return; + GST_DEBUG_OBJECT (self, "Stop (transient %d)", transient); tick_cb (self); -- cgit v1.2.1