From bd2497729e65a160c2453af996d2802e399132e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Sun, 29 Oct 2006 19:08:01 +0000 Subject: ext/dts/gstdtsdec.c: Fix flow handling and buffer refcounting (gst_pad_push() takes ownership of the buffer passed to... Original commit message from CVS: * ext/dts/gstdtsdec.c: (gst_dtsdec_handle_frame): Fix flow handling and buffer refcounting (gst_pad_push() takes ownership of the buffer passed to it, the buffer does not have to be unreffed no matter what flow value gst_pad_push() returns). --- ext/dts/gstdtsdec.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) (limited to 'ext/dts/gstdtsdec.c') diff --git a/ext/dts/gstdtsdec.c b/ext/dts/gstdtsdec.c index 6b913dc6d..c2b3329c2 100644 --- a/ext/dts/gstdtsdec.c +++ b/ext/dts/gstdtsdec.c @@ -435,10 +435,8 @@ gst_dtsdec_handle_frame (GstDtsDec * dts, guint8 * data, result = gst_pad_alloc_buffer_and_set_caps (dts->srcpad, 0, (SAMPLE_WIDTH / 8) * 256 * num_c, GST_PAD_CAPS (dts->srcpad), &out); - if (result != GST_FLOW_OK) { - GST_ELEMENT_ERROR (dts, RESOURCE, FAILED, (NULL), ("Out of memory")); - goto done; - } + if (result != GST_FLOW_OK) + break; GST_BUFFER_TIMESTAMP (out) = dts->current_ts; GST_BUFFER_DURATION (out) = GST_SECOND * 256 / dts->sample_rate; @@ -457,16 +455,10 @@ gst_dtsdec_handle_frame (GstDtsDec * dts, guint8 * data, /* push on */ result = gst_pad_push (dts->srcpad, out); - if (result != GST_FLOW_OK) { - gst_buffer_unref (out); - goto done; - } - - + if (result != GST_FLOW_OK) + break; } -done: - return result; } -- cgit v1.2.1