From aa2b8f179e58d75fd2ac9c2721f9eb6e36f1b6f4 Mon Sep 17 00:00:00 2001 From: Vincent Penquerc'h Date: Thu, 10 Apr 2014 17:55:21 +0100 Subject: faac: fix faac API error checking Coverity 1139790 --- ext/faac/gstfaac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'ext/faac') diff --git a/ext/faac/gstfaac.c b/ext/faac/gstfaac.c index 0619296dc..4bea1ceb5 100644 --- a/ext/faac/gstfaac.c +++ b/ext/faac/gstfaac.c @@ -633,6 +633,7 @@ gst_faac_handle_frame (GstAudioEncoder * enc, GstBuffer * in_buf) GstFlowReturn ret = GST_FLOW_OK; GstBuffer *out_buf; gsize size, ret_size; + int enc_ret; GstMapInfo map, omap; guint8 *data; GstAudioInfo *info = @@ -657,9 +658,10 @@ gst_faac_handle_frame (GstAudioEncoder * enc, GstBuffer * in_buf) size = 0; } - if (G_UNLIKELY ((ret_size = faacEncEncode (faac->handle, (gint32 *) data, + if (G_UNLIKELY ((enc_ret = faacEncEncode (faac->handle, (gint32 *) data, size / (info->finfo->width / 8), omap.data, omap.size)) < 0)) goto encode_failed; + ret_size = enc_ret; if (in_buf) gst_buffer_unmap (in_buf, &map); -- cgit v1.2.1