From f04b20e59e64cf1ebbc67484500892a5387dba9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Manuel=20J=C3=A1quez=20Leal?= Date: Mon, 29 Jan 2018 12:50:36 +0100 Subject: gdpdepay: don't allocation query if caps aren't fixed When querying downstream for allocation, and the source caps hasn't set its caps, using ANY by default, it raises a critical message in console: CRITICAL **: gst_video_info_from_caps: assertion 'gst_caps_is_fixed (caps)' failed This patch bails out decide_allocation() if the caps aren't fixed. https://bugzilla.gnome.org/show_bug.cgi?id=789476 --- gst/gdp/gstgdpdepay.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'gst/gdp') diff --git a/gst/gdp/gstgdpdepay.c b/gst/gdp/gstgdpdepay.c index 4d2093870..750571e6f 100644 --- a/gst/gdp/gstgdpdepay.c +++ b/gst/gdp/gstgdpdepay.c @@ -560,6 +560,11 @@ gst_gdp_depay_decide_allocation (GstGDPDepay * gdpdepay) return; } + if (!gst_caps_is_fixed (caps)) { + GST_LOG_OBJECT (gdpdepay, "Caps on src pad are not fixed. Not querying."); + return; + } + query = gst_query_new_allocation (caps, TRUE); if (!gst_pad_peer_query (gdpdepay->srcpad, query)) { GST_WARNING_OBJECT (gdpdepay, "Peer allocation query failed."); -- cgit v1.2.1