From 4260f8a1204674253fc5003d78a7ee8a09d442d1 Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Mon, 20 Nov 2017 17:06:07 +0100 Subject: all: Fix left-shift undefined behaviour Cast to the target type before shifting (or use macro if available) --- gst/mxf/mxftypes.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'gst/mxf') diff --git a/gst/mxf/mxftypes.c b/gst/mxf/mxftypes.c index ba7704b8c..e077f3f23 100644 --- a/gst/mxf/mxftypes.c +++ b/gst/mxf/mxftypes.c @@ -250,9 +250,7 @@ mxf_uuid_hash (const MXFUUID * uuid) g_return_val_if_fail (uuid != NULL, 0); for (i = 0; i < 4; i++) - ret ^= (uuid->u[i * 4 + 0] << 24) | - (uuid->u[i * 4 + 1] << 16) | - (uuid->u[i * 4 + 2] << 8) | (uuid->u[i * 4 + 3] << 0); + ret ^= GST_READ_UINT32_BE (uuid->u + i * 4); return ret; } -- cgit v1.2.1