From 89fbcc71d96370c0edb06bdc3e71a48d340f1f12 Mon Sep 17 00:00:00 2001
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date: Fri, 10 Jul 2020 18:03:20 -0400
Subject: ristsink: Fix error handling on bad DNS

This will properly print the DNS being attempted to resolved and avoid
trying to unref a NULL pointer.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1433>
---
 gst/rist/gstristsink.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

(limited to 'gst/rist')

diff --git a/gst/rist/gstristsink.c b/gst/rist/gstristsink.c
index 464b0719d..6622257c9 100644
--- a/gst/rist/gstristsink.c
+++ b/gst/rist/gstristsink.c
@@ -700,10 +700,8 @@ gst_rist_sink_setup_rtcp_socket (GstRistSink * sink, RistSenderBond * bond)
 
 dns_resolve_failed:
   GST_ELEMENT_ERROR (sink, RESOURCE, NOT_FOUND,
-      ("Could not resolve hostname '%s'", GST_STR_NULL (remote_addr)),
+      ("Could not resolve hostname '%s'", GST_STR_NULL (bond->address)),
       ("DNS resolver reported: %s", error->message));
-  g_free (remote_addr);
-  g_object_unref (iaddr);
   g_error_free (error);
   return GST_STATE_CHANGE_FAILURE;
 }
-- 
cgit v1.2.1