From 88d7141ba404bf00d4c720fc66774be24e50b93e Mon Sep 17 00:00:00 2001 From: "Jan Alexander Steffens (heftig)" Date: Fri, 7 May 2021 11:13:46 +0200 Subject: rtpsink: Return proper pad from _request_new_pad Bizarrely, it returned a pad from the child rtpbin. I noticed because our application leaked the implicitly created ghost pad. Make an explicit ghost pad so this works properly. Part-of: --- gst/rtp/gstrtpsink.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'gst/rtp') diff --git a/gst/rtp/gstrtpsink.c b/gst/rtp/gstrtpsink.c index 83739fb01..4ef6ca755 100644 --- a/gst/rtp/gstrtpsink.c +++ b/gst/rtp/gstrtpsink.c @@ -241,7 +241,7 @@ gst_rtp_sink_request_new_pad (GstElement * element, GstPadTemplate * templ, const gchar * name, const GstCaps * caps) { GstRtpSink *self = GST_RTP_SINK (element); - GstPad *pad = NULL; + GstPad *rpad, *pad = NULL; if (self->rtpbin == NULL) { GST_ELEMENT_ERROR (self, CORE, MISSING_PLUGIN, (NULL), @@ -253,7 +253,12 @@ gst_rtp_sink_request_new_pad (GstElement * element, return NULL; GST_RTP_SINK_LOCK (self); - pad = gst_element_request_pad_simple (self->rtpbin, "send_rtp_sink_%u"); + rpad = gst_element_request_pad_simple (self->rtpbin, "send_rtp_sink_%u"); + if (rpad) { + pad = gst_ghost_pad_new (GST_PAD_NAME (rpad), rpad); + gst_element_add_pad (element, pad); + gst_clear_object (&rpad); + } GST_RTP_SINK_UNLOCK (self); g_return_val_if_fail (pad != NULL, NULL); -- cgit v1.2.1