diff options
| author | Jordan Petridis <jpetridis@gnome.org> | 2020-06-11 20:57:58 +0300 |
|---|---|---|
| committer | Tim-Philipp Müller <tim@centricular.com> | 2020-10-14 15:14:14 +0100 |
| commit | 53432a5efd46b1b0d4fb0c0cf7873786e92a93e7 (patch) | |
| tree | c980d856cfe20e5c34f9047cc5c67efa91ddd09c | |
| parent | c1b4b0f80505cc8bf5579f56dd0028f40e611159 (diff) | |
| download | gstreamer-plugins-base-53432a5efd46b1b0d4fb0c0cf7873786e92a93e7.tar.gz | |
libvisual: use gst_element_class_set_metadata when passing dynamic strings
gst_element_class_set_metadata is meant to only be used with
static or inlined strings, which isn't the case for this element
resulting in use-after-free later on.
https://gstreamer.freedesktop.org/documentation/gstreamer/gstelement.html?gi-language=c#gst_element_class_set_static_metadata
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/871>
| -rw-r--r-- | ext/libvisual/visual.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ext/libvisual/visual.c b/ext/libvisual/visual.c index 2ed94f0fc..47ce29bcb 100644 --- a/ext/libvisual/visual.c +++ b/ext/libvisual/visual.c @@ -106,7 +106,7 @@ gst_visual_class_init (gpointer g_class, gpointer class_data) gst_element_class_add_static_pad_template (element_class, &src_template); gst_element_class_add_static_pad_template (element_class, &sink_template); - gst_element_class_set_static_metadata (element_class, + gst_element_class_set_metadata (element_class, longname, "Visualization", klass->plugin->info->about, "Benjamin Otte <otte@gnome.org>"); |