diff options
| author | Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> | 2015-10-06 15:20:51 +0200 |
|---|---|---|
| committer | Tim-Philipp Müller <tim@centricular.com> | 2015-10-25 11:26:20 +0000 |
| commit | d9ebc67f0dd0a70681f8636494d138ce54e6dbdd (patch) | |
| tree | 6667528fb26569b5d49d420578d3ca6fa351512e | |
| parent | cfb6d6e7b44fedddeb6aa6f0fdb1189541d3d035 (diff) | |
| download | gstreamer-plugins-base-d9ebc67f0dd0a70681f8636494d138ce54e6dbdd.tar.gz | |
decodebin: fix event leak
As stated in GST_PAD_PROBE_HANDLED's documentation, we are
supposed to unref the event before returning.
Fixes an event leak in the validate.hls.playback.play_15s.hls_bibbop
validate scenario.
https://bugzilla.gnome.org/show_bug.cgi?id=754459
| -rw-r--r-- | gst/playback/gstdecodebin2.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/gst/playback/gstdecodebin2.c b/gst/playback/gstdecodebin2.c index cf3a2d117..d5bd5eec2 100644 --- a/gst/playback/gstdecodebin2.c +++ b/gst/playback/gstdecodebin2.c @@ -2931,6 +2931,7 @@ sink_pad_event_probe (GstPad * pad, GstPadProbeInfo * info, gpointer user_data) if (otherpeer) { GST_DEBUG_OBJECT (otherpeer, "Attempting to forward event"); if (gst_pad_send_event (otherpeer, gst_event_ref (event))) { + gst_event_unref (event); proberet = GST_PAD_PROBE_HANDLED; } gst_object_unref (otherpeer); |