summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatthew Waters <matthew@centricular.com>2016-11-23 21:27:55 +1100
committerMatthew Waters <matthew@centricular.com>2016-11-23 21:38:18 +1100
commit71f367c297ccfeebf7ff54439d9e69e601efd949 (patch)
tree70510cd8d540230dea1545b76d7d095516a18c62
parent8892d6a81f5cb4b0c6f5b29343f92f6f1a682d4c (diff)
downloadgstreamer-plugins-base-71f367c297ccfeebf7ff54439d9e69e601efd949.tar.gz
typefind: bounds check windows ico detection
Fixes out of bounds read https://bugzilla.gnome.org/show_bug.cgi?id=774902
-rw-r--r--gst/typefind/gsttypefindfunctions.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/gst/typefind/gsttypefindfunctions.c b/gst/typefind/gsttypefindfunctions.c
index 63e1de983..40fe3d44f 100644
--- a/gst/typefind/gsttypefindfunctions.c
+++ b/gst/typefind/gsttypefindfunctions.c
@@ -5128,6 +5128,8 @@ windows_icon_typefind (GstTypeFind * find, gpointer user_data)
gint32 size, offset;
datalen = gst_type_find_get_length (find);
+ if (datalen < 18)
+ return;
if ((data = gst_type_find_peek (find, 0, 6)) == NULL)
return;