diff options
| author | Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> | 2016-05-16 15:39:02 +0200 |
|---|---|---|
| committer | Sebastian Dröge <sebastian@centricular.com> | 2016-05-20 09:07:05 +0300 |
| commit | bb015bad32475849e6df16a2f588ec32a8bde270 (patch) | |
| tree | 093b14597d8a27d1dae706a4a9aa5ce24d37c0ca | |
| parent | 648a07f367fe290164ca3e19d709b81ee67c22ba (diff) | |
| download | gstreamer-plugins-base-bb015bad32475849e6df16a2f588ec32a8bde270.tar.gz | |
playbin: fix suburidecodebin leak
We take a ref before removing which was never freeded.
The element is still alive anyway because the group has its own ref as
well.
Fix a leak with the 'test_suburi_error_wrongproto' test.
https://bugzilla.gnome.org/show_bug.cgi?id=766515
| -rw-r--r-- | gst/playback/gstplaybin2.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/gst/playback/gstplaybin2.c b/gst/playback/gstplaybin2.c index b4b74780f..ad6360008 100644 --- a/gst/playback/gstplaybin2.c +++ b/gst/playback/gstplaybin2.c @@ -2991,6 +2991,7 @@ gst_play_bin_handle_message (GstBin * bin, GstMessage * msg) gst_object_ref (group->suburidecodebin); gst_bin_remove (bin, group->suburidecodebin); gst_element_set_locked_state (group->suburidecodebin, FALSE); + gst_object_unref (group->suburidecodebin); GST_SOURCE_GROUP_LOCK (group); g_free (group->suburi); |