diff options
| author | Tim-Philipp Müller <tim@centricular.com> | 2014-03-05 00:35:30 +0000 |
|---|---|---|
| committer | Tim-Philipp Müller <tim@centricular.com> | 2014-04-12 13:42:29 +0100 |
| commit | 72f328fbde0f902b0fb31443c5c3d65d9f5e016d (patch) | |
| tree | 69431e5130cd6452ffc24b3b99a8a2c0b54a1b60 | |
| parent | f74951925fe91e16a61c9214e96664e5c91c085f (diff) | |
| download | gstreamer-plugins-base-72f328fbde0f902b0fb31443c5c3d65d9f5e016d.tar.gz | |
typefindfunctions: lower H.263 typefinder max probability
The typefinder returns LIKELY for as little as one possible
sync and no bad sync (not even taking into account how much
data was looked at for that). It's generally just not fit
for purpose, so should just not return anything like LIKELY
at all ever, even more so since it only recognises one out
of ten H263 files, and likes to mis-detect mp3s as H263.
https://bugzilla.gnome.org/show_bug.cgi?id=700770
https://bugzilla.gnome.org/show_bug.cgi?id=725644
| -rw-r--r-- | gst/typefind/gsttypefindfunctions.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/gst/typefind/gsttypefindfunctions.c b/gst/typefind/gsttypefindfunctions.c index 3135a61c2..88836b8c9 100644 --- a/gst/typefind/gsttypefindfunctions.c +++ b/gst/typefind/gsttypefindfunctions.c @@ -2587,9 +2587,9 @@ h263_video_type_find (GstTypeFind * tf, gpointer unused) data_scan_ctx_advance (tf, &c, 1); } - if (good > 0 && bad == 0) - gst_type_find_suggest (tf, GST_TYPE_FIND_LIKELY, H263_VIDEO_CAPS); - else if (good > 2 * bad) + GST_LOG ("good: %d, bad: %d", good, bad); + + if (good > 2 * bad) gst_type_find_suggest (tf, GST_TYPE_FIND_POSSIBLE, H263_VIDEO_CAPS); return; |