From cb6cbf4d6ca4e4815322976e9e119cd492ad8c34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Fri, 20 Jan 2017 08:02:38 +0200 Subject: samiparse: Check that the string has a non-zero length before overwriting the last byte with '\0' https://bugzilla.gnome.org/show_bug.cgi?id=777502 --- gst/subparse/samiparse.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gst/subparse/samiparse.c b/gst/subparse/samiparse.c index 517e959a9..377c6d730 100644 --- a/gst/subparse/samiparse.c +++ b/gst/subparse/samiparse.c @@ -504,7 +504,8 @@ html_context_handle_element (HtmlContext * ctxt, } length = strlen (attr_value); - if (attr_value[length - 1] == '"' || attr_value[length - 1] == '\'') { + if (length > 0 && (attr_value[length - 1] == '"' + || attr_value[length - 1] == '\'')) { attr_value[length - 1] = '\0'; } -- cgit v1.2.1