diff options
| author | Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> | 2014-04-10 16:53:25 +0100 |
|---|---|---|
| committer | Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> | 2014-04-10 16:56:13 +0100 |
| commit | 16a85fc66449b406053e62dffd54e6b93bd341d9 (patch) | |
| tree | 7b56dc8c0855f91a27fa352bbe78131a862066a2 | |
| parent | 6b887060b1d6eadf5ea47a17cb9dfd62050609b7 (diff) | |
| download | gstreamer-plugins-ugly-16a85fc66449b406053e62dffd54e6b93bd341d9.tar.gz | |
dvdread: avoid intermediate promotion to signed
We should not reach the dangerous range here, though.
Coverity 206491, 206492, 1139856
| -rw-r--r-- | ext/dvdread/dvdreadsrc.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/ext/dvdread/dvdreadsrc.c b/ext/dvdread/dvdreadsrc.c index 74ee8560..e928559a 100644 --- a/ext/dvdread/dvdreadsrc.c +++ b/ext/dvdread/dvdreadsrc.c @@ -590,7 +590,7 @@ gst_dvd_read_src_goto_title (GstDvdReadSrc * src, gint title, gint angle) for (j = 0; j < src->vts_tmapt->tmap[i].nr_of_entries; j++) { guint64 time; - time = src->vts_tmapt->tmap[i].tmu * (j + 1) * GST_SECOND; + time = (guint64) src->vts_tmapt->tmap[i].tmu * (j + 1) * GST_SECOND; GST_LOG_OBJECT (src, "Time: %" GST_TIME_FORMAT " VOBU " "Sector: 0x%08x %s", GST_TIME_ARGS (time), src->vts_tmapt->tmap[i].map_ent[j] & 0x7fffffff, @@ -695,7 +695,7 @@ gst_dvd_read_src_get_time_for_sector (GstDvdReadSrc * src, guint sector) for (i = 0; i < src->vts_tmapt->nr_of_tmaps; ++i) { for (j = 0; j < src->vts_tmapt->tmap[i].nr_of_entries; ++j) { if ((src->vts_tmapt->tmap[i].map_ent[j] & 0x7fffffff) == sector) - return src->vts_tmapt->tmap[i].tmu * (j + 1) * GST_SECOND; + return (guint64) src->vts_tmapt->tmap[i].tmu * (j + 1) * GST_SECOND; } } @@ -718,7 +718,8 @@ gst_dvd_read_src_get_sector_from_time (GstDvdReadSrc * src, GstClockTime ts) for (j = 0; j < src->vts_tmapt->tmap[src->ttn - 1].nr_of_entries; ++j) { GstClockTime entry_time; - entry_time = src->vts_tmapt->tmap[src->ttn - 1].tmu * (j + 1) * GST_SECOND; + entry_time = + (guint64) src->vts_tmapt->tmap[src->ttn - 1].tmu * (j + 1) * GST_SECOND; if (entry_time <= ts) { sector = src->vts_tmapt->tmap[src->ttn - 1].map_ent[j] & 0x7fffffff; } |