diff options
author | Mark Nauwelaerts <mnauw@users.sourceforge.net> | 2017-08-09 19:31:56 +0200 |
---|---|---|
committer | Mark Nauwelaerts <mnauw@users.sourceforge.net> | 2017-08-09 19:31:56 +0200 |
commit | fc826ac6dcf49ffade8baf0c33698f4d1340f1b9 (patch) | |
tree | 9f1df30b8af7b5a561d44e8bf7c176841537f8ec /ext/x264/gstx264enc.c | |
parent | 861cff5da13614f50636681d9039a731e279b695 (diff) | |
download | gstreamer-plugins-ugly-fc826ac6dcf49ffade8baf0c33698f4d1340f1b9.tar.gz |
x264enc: add FIXME note for future configuration cleanup
Diffstat (limited to 'ext/x264/gstx264enc.c')
-rw-r--r-- | ext/x264/gstx264enc.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/ext/x264/gstx264enc.c b/ext/x264/gstx264enc.c index 78ee126f..b836dfac 100644 --- a/ext/x264/gstx264enc.c +++ b/ext/x264/gstx264enc.c @@ -1692,6 +1692,14 @@ gst_x264_enc_init_encoder (GstX264Enc * encoder) encoder->x264param.analyse.b_psnr = 0; + /* FIXME 2.0 make configuration more sane and consistent with x264 cmdline: + * + split pass property into a pass property (pass1/2/3 enum) and rc-method + * + bitrate property should only be used in case of CBR method + * + vbv bitrate/buffer should have separate configuration that is then + * applied independently of the mode: + * + either using properties (new) vbv-maxrate and (renamed) vbv-bufsize + * + or dropping vbv-buf-capacity altogether and simply using option-string + */ switch (encoder->pass) { case GST_X264_ENC_PASS_QUANT: encoder->x264param.rc.i_rc_method = X264_RC_CQP; |