From 5e3fde85692221d42d93ec98fffa0d6f1aa308f7 Mon Sep 17 00:00:00 2001 From: He Junyan Date: Sat, 9 Jan 2021 16:05:48 +0800 Subject: decoder: AV1: Fix a static analysis problem of update_state(). No need to check the picture pointer after we have already dereferenced it. Fix: #298 Part-of: --- gst-libs/gst/vaapi/gstvaapidecoder_av1.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) (limited to 'gst-libs') diff --git a/gst-libs/gst/vaapi/gstvaapidecoder_av1.c b/gst-libs/gst/vaapi/gstvaapidecoder_av1.c index 062b310b..a4faf5d2 100644 --- a/gst-libs/gst/vaapi/gstvaapidecoder_av1.c +++ b/gst-libs/gst/vaapi/gstvaapidecoder_av1.c @@ -978,13 +978,8 @@ av1_decoder_update_state (GstVaapiDecoderAV1 * decoder, for (i = 0; i < GST_AV1_NUM_REF_FRAMES; i++) { if ((picture->frame_header.refresh_frame_flags >> i) & 1) { - if (picture) { - GST_LOG ("reference frame %p to ref slot:%d", picture, i); - gst_vaapi_picture_replace (&priv->ref_frames[i], picture); - } else { - GST_ERROR ("we miss some reference frame for ref slot:%d", i); - gst_vaapi_picture_replace (&priv->ref_frames[i], NULL); - } + GST_LOG ("reference frame %p to ref slot:%d", picture, i); + gst_vaapi_picture_replace (&priv->ref_frames[i], picture); } } -- cgit v1.2.1