summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTim-Philipp Müller <tim@centricular.com>2023-05-16 16:17:05 +0100
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>2023-05-17 07:53:16 +0000
commit556449a9177b86b755840118ea6eedcd649b8732 (patch)
treef6e390353d822d155060b1c9b66bdfb1febcf3b5
parent59637a244cc9d71f358dc6a40824bbe77a82dddc (diff)
downloadgstreamer-556449a9177b86b755840118ea6eedcd649b8732.tar.gz
Revert "webrtc/nice: support consent-freshness RFC7675"
This reverts commit 0161687505156f54ff38b976668804ac2763a863. This causes problems when the connection is congested because libnice uses a too agressive timeout contrary to the spec, so it's easy for consent to lapse and streaming to stop if there's packet loss. Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4649>
-rw-r--r--subprojects/gst-plugins-bad/gst-libs/gst/webrtc/nice/nice.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/webrtc/nice/nice.c b/subprojects/gst-plugins-bad/gst-libs/gst/webrtc/nice/nice.c
index a59f578c4c..f62eb91b72 100644
--- a/subprojects/gst-plugins-bad/gst-libs/gst/webrtc/nice/nice.c
+++ b/subprojects/gst-plugins-bad/gst-libs/gst/webrtc/nice/nice.c
@@ -1583,7 +1583,6 @@ gst_webrtc_nice_constructed (GObject * object)
options |= NICE_AGENT_OPTION_ICE_TRICKLE;
options |= NICE_AGENT_OPTION_REGULAR_NOMINATION;
- options |= NICE_AGENT_OPTION_CONSENT_FRESHNESS;
ice->priv->nice_agent = nice_agent_new_full (ice->priv->main_context,
NICE_COMPATIBILITY_RFC5245, options);