From f722d9c428615db546248f449b5130a7f65a1439 Mon Sep 17 00:00:00 2001 From: Elliot Chen Date: Thu, 2 Mar 2023 18:09:54 +0800 Subject: gstplay: avoid getting property of playbin2 if subtitle_sid is null There is a probability of getting "current-text" property when play with playbin3, and this property is available only in playbin2. Part-of: --- subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c index f99bbe1bcd..c88d8e94c2 100644 --- a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c +++ b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c @@ -1762,9 +1762,11 @@ gst_play_subtitle_info_update (GstPlay * self, GstPlayStreamInfo * stream_info) g_object_get (G_OBJECT (self->playbin), "current-suburi", &suburi, NULL); if (suburi) { - if (self->use_playbin3 && self->subtitle_sid) { - if (g_str_equal (self->subtitle_sid, stream_info->stream_id)) + if (self->use_playbin3) { + if (self->subtitle_sid && + g_str_equal (self->subtitle_sid, stream_info->stream_id)) { info->language = g_path_get_basename (suburi); + } } else { g_object_get (G_OBJECT (self->playbin), "current-text", &text_index, NULL); -- cgit v1.2.1