From fd0acb4dfb74833ea16e2979e11903623ce147c8 Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Thu, 21 Jul 2016 10:52:30 +0200 Subject: basetransform: fix pool leak when early returning in decide_allocation https://bugzilla.gnome.org/show_bug.cgi?id=769023 --- libs/gst/base/gstbasetransform.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libs/gst/base/gstbasetransform.c b/libs/gst/base/gstbasetransform.c index de04a4817a..5b08cec431 100644 --- a/libs/gst/base/gstbasetransform.c +++ b/libs/gst/base/gstbasetransform.c @@ -960,6 +960,9 @@ gst_base_transform_default_decide_allocation (GstBaseTransform * trans, return TRUE; config_failed: + if (pool) + gst_object_unref (pool); + GST_ELEMENT_ERROR (trans, RESOURCE, SETTINGS, ("Failed to configure the buffer pool"), ("Configuration is most likely invalid, please report this issue.")); -- cgit v1.2.1