From 7f231c2d8a8d7f8cae4225e12baf9c33f07a3af9 Mon Sep 17 00:00:00 2001 From: Nirbheek Chauhan Date: Mon, 2 Mar 2020 11:05:41 +0530 Subject: Disable rust feature option by default The only requirement for the rust plugins is that a rust toolchain be present on the system. This is problematic: 1. This means gst-build on Windows is broken by default if you have a Rust toolchain, since glib can't be used uninstalled 2. No output is printed on Windows at all while the rust plugins are being built. `custom_target()`'s `console:` keyword argument seems to be broken on some Windows shells. 3. Even on Linux/macOS having this enabled by default is problematic since it more than doubles the total build time. 4. The biggest issue with having it enabled by default is that it does not dependency tracking, so we always run `cargo`, which might update crates. This increases friction when you're working on unrelated code. --- meson_options.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'meson_options.txt') diff --git a/meson_options.txt b/meson_options.txt index b7b7440879..686c67556f 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -11,7 +11,7 @@ option('vaapi', type : 'feature', value : 'auto') option('sharp', type : 'feature', value : 'disabled') option('custom_subprojects', type : 'string', value : '', description : 'Comma-separated project names') option('gst-examples', type : 'feature', value : 'auto', description : 'Build gst-examples') -option('rs', type : 'feature', value : 'auto') +option('rs', type : 'feature', value : 'disabled') # Common options, automatically inherited by subprojects option('examples', type : 'feature', value : 'auto', description : 'Build examples') -- cgit v1.2.1