summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatthias Clasen <mclasen@redhat.com>2019-12-23 23:17:29 -0500
committerMatthias Clasen <mclasen@redhat.com>2019-12-23 23:19:57 -0500
commit0d6cff45c3acb3288eaea5a123b2ee81ec7d12d6 (patch)
tree86608c54b434e484ac2ffe3b623a5b81655b4ce5
parenteeb896d6481737d67074ce989f1b2826e86652dd (diff)
downloadgtk+-0d6cff45c3acb3288eaea5a123b2ee81ec7d12d6.tar.gz
accelgroup: Fix a buffer overrun
gtk_accelerator_parse_with_keycode can overrun its buffer for certain inputs. Fixes: https://gitlab.gnome.org/GNOME/gtk/issues/2325
-rw-r--r--gtk/gtkaccelgroup.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/gtk/gtkaccelgroup.c b/gtk/gtkaccelgroup.c
index 3b514d2302..cf32e019f9 100644
--- a/gtk/gtkaccelgroup.c
+++ b/gtk/gtkaccelgroup.c
@@ -1306,9 +1306,9 @@ gtk_accelerator_parse_with_keycode (const gchar *accelerator,
last_ch = *accelerator;
while (last_ch && last_ch != '>')
{
- last_ch = *accelerator;
accelerator += 1;
len -= 1;
+ last_ch = *accelerator;
}
}
}