summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatthias Clasen <mclasen@redhat.com>2020-10-15 15:16:06 -0400
committerMatthias Clasen <mclasen@redhat.com>2020-10-15 16:32:55 -0400
commit4e04c396095b7e4b70f0635ded6241a61a62ada8 (patch)
tree3d1e7307a47d1f3c221eadeeac278ae1fc3f6899
parent0bd5a96d71562c4820cf74fdc05ce5c891936bad (diff)
downloadgtk+-4e04c396095b7e4b70f0635ded6241a61a62ada8.tar.gz
emojicompletion: Avoid a memory overrun
Don't read beyond the beginning of the string. Fixes: #3245
-rw-r--r--gtk/gtkemojicompletion.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/gtk/gtkemojicompletion.c b/gtk/gtkemojicompletion.c
index 712418850a..31669c85d5 100644
--- a/gtk/gtkemojicompletion.c
+++ b/gtk/gtkemojicompletion.c
@@ -115,7 +115,8 @@ next:
break;
}
}
- while (g_unichar_isalnum (g_utf8_get_char (p)) || *p == '_' || *p == ' ');
+ while (p > text &&
+ (g_unichar_isalnum (g_utf8_get_char (p)) || *p == '_' || *p == ' '));
if (found_candidate)
n_matches = populate_completion (completion, p, 0);