diff options
| -rw-r--r-- | ChangeLog | 8 | ||||
| -rw-r--r-- | ChangeLog.pre-2-10 | 8 | ||||
| -rw-r--r-- | gdk/x11/gdkdnd-x11.c | 2 | ||||
| -rw-r--r-- | gdk/x11/gdkwindow-x11.c | 4 |
4 files changed, 22 insertions, 0 deletions
@@ -1,3 +1,11 @@ +2006-08-15 Matthias Clasen <mclasen@redhat.com> + + * gdk/x11/gdkdnd-x11.c (gdk_window_register_dnd): + * gdk/x11/gdkwindow-x11.c (gdk_window_set_decorations): + (gdk_window_set_functions): Zero out some stack-allocated + X structures, to avoid valgrind warnings about uninitialized + memory. (#349382, David Baron) + 2006-08-14 Emmanuele Bassi <ebassi@gnome.org> * gtk/gtkrecentchooser.c: diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index eea2417b96..c1fd3dacae 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,11 @@ +2006-08-15 Matthias Clasen <mclasen@redhat.com> + + * gdk/x11/gdkdnd-x11.c (gdk_window_register_dnd): + * gdk/x11/gdkwindow-x11.c (gdk_window_set_decorations): + (gdk_window_set_functions): Zero out some stack-allocated + X structures, to avoid valgrind warnings about uninitialized + memory. (#349382, David Baron) + 2006-08-14 Emmanuele Bassi <ebassi@gnome.org> * gtk/gtkrecentchooser.c: diff --git a/gdk/x11/gdkdnd-x11.c b/gdk/x11/gdkdnd-x11.c index 7e0961c771..47178f2584 100644 --- a/gdk/x11/gdkdnd-x11.c +++ b/gdk/x11/gdkdnd-x11.c @@ -3754,6 +3754,8 @@ gdk_window_register_dnd (GdkWindow *window) motif_drag_receiver_info_atom = gdk_x11_get_xatom_by_name_for_display (display, "_MOTIF_DRAG_RECEIVER_INFO"); + /* initialize to zero to avoid writing uninitialized data to socket */ + memset(&info, 0, sizeof(info)); info.byte_order = local_byte_order; info.protocol_version = 0; info.protocol_style = XmDRAG_DYNAMIC; diff --git a/gdk/x11/gdkwindow-x11.c b/gdk/x11/gdkwindow-x11.c index 80f5ff3842..2a71b22ada 100644 --- a/gdk/x11/gdkwindow-x11.c +++ b/gdk/x11/gdkwindow-x11.c @@ -5021,6 +5021,8 @@ gdk_window_set_decorations (GdkWindow *window, g_return_if_fail (GDK_IS_WINDOW (window)); + /* initialize to zero to avoid writing uninitialized data to socket */ + memset(&hints, 0, sizeof(hints)); hints.flags = MWM_HINTS_DECORATIONS; hints.decorations = decorations; @@ -5089,6 +5091,8 @@ gdk_window_set_functions (GdkWindow *window, g_return_if_fail (GDK_IS_WINDOW (window)); + /* initialize to zero to avoid writing uninitialized data to socket */ + memset(&hints, 0, sizeof(hints)); hints.flags = MWM_HINTS_FUNCTIONS; hints.functions = functions; |