| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
We don't ever start up in Search mode, so we don't need an extra check for that mode, yet.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
| |
Otherwise it's not very useful... :)
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
| |
There's no real asynchronicity going on, anyway, so let's do both within
a single iteration of the idle handler.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
|
| |
The mtime from GtkRecentManager may not the same as the file's actual
mtime, so the final result could appear unsorted to the user. Instead,
we will let the view do the sorting.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
| |
Apparently schemas are part of the ABI contract; running apps crash if a
schema disapppears and they happen to access it.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
| |
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
| |
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
|
| |
Years ago, when the location entry only appeared in a popup window, it used to appear
populated with the current folder's path. We had some logic to do this, but since now
the location entry appears in the main dialog, we can do away with that old code.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
| |
We had duplicated code to create the entry in two cases, for Open and for Save modes.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
| |
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
| |
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
| |
This way we can re-create the contents of that box easily without disrupting
the rest of the file chooser.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
| |
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
|
|
|
|
| |
This will be the central function to switch operation modes: stop searches or the recent-files
process; switch widgets, etc.
We factor out the common code from recent_switch_to_browse_mode() and search_switch_to_browse_mode(),
and remove those functions. All the code that switched modes by hand now calls
the central operation_mode_set().
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
| |
That code indeed lives in operation_mode_stop(), so use it instead of
having inlined duplicates.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
| |
We'll now prefix functions to change the impl->operation_mode with 'operation_mode',
for clarity.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Various paths in SAVE or CREATE_FOLDER return from ::should_respond() but
leave an asynchronous process running. This process checks some things
in the user's selection, for example, 'does the file exist, and if so
do we need to bring up an overwrite-confirmation dialog?'. When these
async processes complete *and* it is indeed time for the dialog to
be terminated (via the response-requested signal), we also need to
save the selection to the recently-used list - as ::should_respond() does
by itself in the cases when it can request a response immediately.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
| |
To make life easier for users, when apps don't properly update the recently-used list
after choosing a file, we now do that directly from the file chooser.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
|
|
| |
Basically, don't ever set the current folder, and only use
gtk_file_chooser_set_filename() for 'File/Save As'. This is so
that the file chooser will be able to present its recently-used
lists as appropriate, giving the user good suggestions by default.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
None of the cases where _gtk_file_chooser_entry_set_base_folder() appear to require
the entry highlighting the file's basename. Doing the highlighting actually makes
things look weird in Save/Recent mode if you
1. type a filename
2. click on a recent-folder,
as right after (2) your filename would get its basename highlighted for
no apparent reason.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
| |
The create-folder machinery doesn't handle that case yet; we may enable it later
once we figure out the implications for the GUI.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
It used to be that every part of the file chooser's code would show/hide the widgets
near the pathbar as needed. Now we have two central functions:
path_bar_update()
path_bar_set_mode()
These take care of all the widget shuffling; setting the visibility of the
pathbar, info bar, and Create Folder button as appropriate; setting the contents
of the info bar, etc. - based on the current operation_mode and action.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
| |
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
|
|
| |
We will centralize the place where all the pathbar-related widgets are created:
the location button, the pathbar itself, the Create Folder button, and in
subsequent commits, the info bar as well. We will deal with the pathbar/infobar
as a unit, instead of swapping them in and out in an ad-hoc fashion.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
| |
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
| |
Since the GtkFileChooserEntry already gets the recent-folder set upon it when a recent-folder
is selected, it already can give us the correct fully-formed path.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
| |
This lets us do proper completion in GtkFileChooserEntry even when no base folder
has been set. Completion for relative paths won't work, as usual, as expected.
|
| |
|
|
|
|
| |
This lets the filename entry do completion relative to the selected recent-folder.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
| |
recent-folders list
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
| |
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
| |
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
| |
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
| |
They weren't being selected in the shortcuts bar when those modes were
activated programmatically, instead of through the user selecting
them from the user interface.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In RELOAD_EMPTY mode, when no folder has been selected by the calling app, we now
start showing the recently-used list. The rationale is as follows:
- In Open mode, the user is likely to pick a file he has used recently.
- In Save mode, the user is likely to want a destination folder which
he has used recently.
For the Save case, where we want to present the user with recent folders instead
of recent files, we will make the recent-list do so in subsequent commits.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduces a 'last-folder-uri' GSettings key, where we remember the last-opened
folder from the previous instance of the file chooser.
The idea is that this works globally, across all applications, so it will be
easy to do things like
1. Save an attachment from a mail (or some other file)
2. Open another program
3. Do File/Open and automatically get sent to the folder where (1) happened.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
https://bugzilla.gnome.org/show_bug.cgi?id=644426
|
| |
|
|
|
|
|
|
| |
Now we reparent the browse_path_bar_hbox to that spot in Save mode,
or to be above the file lists in Open mode. The pathbar makes for a very
clear indication of the location to save in.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
| |
And with this we get rid of the craziness of having a separate filter model
for the combobox's model.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
| |
This effectively makes the file chooser always be in 'expanded' mode.
Later, we'll move the pathbar to the 'Save in folder:' line.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
|
| |
This extracts the parent folders from the items in the recently-used
list. We'll use it in the file chooser to present a list of
recently-used folders.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
-Fix the VS2010 property sheet as the DefDir "macro" needs to be updated
as well when the intermediate directories were seperated by project.
-Reinstate build/win32/vs10/gtk+.sln with the correct DOS/Windows EOL so
that file can be correctly recognized by Windows, without the
"Unrecognized Visual Studio Version" problem.
-Update solutions and projects where gtk-demo becomes gtk3-demo, to be
consistent across the board.
|
| |
|
|
| |
This file needs to have DOS/Windows-style EOL...
|
| |
|
|
|
|
|
| |
As Cairo and Cairo-GObject are often built as two seperate DLLs/modules,
set the property sheets to link to both libraries, instead of using the
previous approach where a monolithic Cairo DLL which contains GObject
support is used.
|
| |
|
|
|
|
|
| |
-Remove unneeded tags from projects
-Seperate intermediate directories for projects to avoid rebuilding/
linking on every rebuild and MSBuild errors (et al.) for not being
able to write into build log files as they are in use.
|
| |
|
|
| |
Use G_ENABLE_DEBUG for all debug builds
|
| |
|
|
|
|
|
|
|
| |
size_allocate() allocates the available space for the margin box,
get_allocation() returns the actual space of the content box and those
can be different. And then animations never stop.
If that makes you go "huh?", you might want to read
http://www.w3.org/TR/CSS21/box.html
and the docs for gtk_widget_compute_align().
|
| | |
|
| |
|
|
|
| |
This has to be done also when we switch to the entry, otherwise completion for
non-local URIs won't work.
|
| | |
|
| | |
|
| | |
|
