| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unparenting a GtkListBoxRow can drop its last reference, which
will free its memory. Right after unparenting, though, we were
accessing the row's iter - which assumes that the row is still
alive. This causes a crash when, for example, binding two or
more models to the listbox.
Fix that by storing the iter in a variable, and not trying to
access it after unparenting. After unparenting, the variables
that are potentially garbage were explicitly assigned NULL for
clarity.
Fixes https://gitlab.gnome.org/GNOME/gtk/issues/1258
(cherry picked from commit 5596feae9b51563a33f1bffc6a370e6ba556adb7)
|
| |\
| |
| |
| |
| | |
gtkscrolledwindow: Consider shift key presses when decelerating [gtk3]
See merge request GNOME/gtk!287
|
| | |
| |
| |
| |
| |
| |
| | |
Otherwise horizontal scrolling using the shift key would decelerate
vertically.
Fixes https://gitlab.gnome.org/GNOME/gtk/issues/770
|
| |\ \
| | |
| | |
| | |
| | | |
Make tooltips use gdk_window_move_to_rect()
See merge request GNOME/gtk!293
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In order to make tooltip positioning portable, make use of the
move_to_rect API. Some semantical changes are made, as identical
semantics cannot be implemented using the move-to-rect API.
Primarily the implemented semantics are:
Position the tooltip in the center pixels slightly below (defaults to 4
units below) the tooltipped widget. This is always the case for keyboard
driven tooltips; the case where it tries to avoid the pointer cursor is
not implemented.
For pointer position triggered tooltips, implement the following
additional semantics:
Use the current cursor size to determine the padding used to enlarge the
anchor rectangle. This is to try to avoid the cursor overlapping the
tooltip.
If the anchor rectangle is too tall (meaning if we'd be constrained
and flip on the Y axis, it'd flip too far away from the originally
intended position), rely only on the pointer position to position the
tooltip. The approximate pointer cursor rectangle is used as a anchor
rectangle. Ideally we should use the actual pointer cursor rectangle
(image used as well as hotspot coordinate), but we don't have API to
get that information.
If the anchor rectangle isn't to tall, just make sure the tooltip isn't
too far away from the pointer position on the X axis.
Closes: #134
Closes: #432
Closes: #574
Closes: #579
Closes: #878
|
| | | |
| | |
| | |
| | |
| | | |
Only popups can make use of the move-to-rect semantics so it makes no
sense to try anything other surface type.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Let's just use the fact that a window was mapped as a subsurface to
remap it above another transient parent instead of relying on the more
complicated 'should-map-as-subsurface' helper function.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
gdk/wayland: Avoid idempotent wl_subsurface.set_position calls
See merge request GNOME/gtk!294
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
These may not result on wl_surface.frame callbacks, yet we do trigger
a frame clock tick that would get stuck on the lack of such callback.
https://bugzilla.gnome.org/show_bug.cgi?id=784314
https://gitlab.gnome.org/GNOME/gtk/issues/844
Closes: #844
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |/ / |
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
gtkplacessidebar: Improve error message when unlocking volume fails
See merge request GNOME/gtk!266
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
font chooser widget: Add missing build flags
See merge request GNOME/gtk!290
|
| |/ / /
| | |
| | |
| | |
| | |
| | | |
If we detect HarfBuzz and PangoFT2, GtkFontChooserWidget uses them. So
we need to add CFLAGS and LIBS of them to GTK_DEP_CFLAGS/LIBS. If we
don't add them, MinGW build fails to link.
|
| | | | |
|
| | | |
| | |
| | |
| | | |
The need for center alignment was pointed out by Timm Baeder.
|
| | | |
| | |
| | |
| | | |
use a kwin color picker when we run under kwin.
|
| | | |
| | |
| | |
| | | |
This is just moving this check around.
|
| | | |
| | |
| | |
| | | |
This uses the org.kde.kwin.ColorPicker interface.
|
| | |/
|/| |
|
| | | |
|
| | |
| |
| |
| | |
These functions are gone in GTK+ 4, so deprecate them here.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
CSD titlebar are included in the focus-chain. The logic used makes sure that the
initial focus avoids the titlebar, but tabbing around will eventually get there.
This logic fails in case the window has no other focusable widgets apart from
the ones in the header-bar. If this happens keynav focus will be lost. To handle
the above scenario, we need to fallback to focus the header-bar (if any).
Fixes: https://gitlab.gnome.org/GNOME/gnome-software/issues/404
|
| | |
| |
| |
| | |
The color picker shows up here.
|
| | | |
|
| | |
| |
| |
| | |
This will help in debugging issues.
|
| | |
| |
| |
| |
| | |
This adds a GtkColorPicker implementation that talks
to gnome-shell to get a color.
|
| | |
| |
| |
| |
| | |
This adds a GtkColorPicker implementation that talks
to the screnshot portal to get a color.
|
| | |
| |
| |
| |
| | |
The button is shown if we have a GtkColorPicker implementation.
Currently, there are none, so the button is never shown.
|
| | |
| |
| |
| | |
This will be used in the color chooser, in subsequent commits.
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
Replace gtk_text_input with text_input_unstable_v3 support
See merge request GNOME/gtk!272
|
| | | |
| | |
| | |
| | | |
The wayland input module now represents text-input-unstable-v3 support, while the old module supporting gtk-text-input was renamed to gtkwayland.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Gdk-Win32: Correct handling of transient state changes
See merge request GNOME/gtk!248
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
gdk_win32_window_set_transient_for() behaves incorrectly when
called in sequence with the same arguments. This fix ensures it
always operates correctly.
In some cases this function gets called multiple times with the
same arguments, e.g. when tooltips are shown.
See issue #1214
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
These icons are very new in the Adwaita icon theme, so we can't
rely on them being widely available, and will just include them
for now.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is more reliable than using text-style Emoji
which may not be present.
Based on work by Julian Sparber.
|
| | |/ /
|/| | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
imwayland: fix potential leak of attr list
See merge request GNOME/gtk!277
|
