| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
In some cases, with bpp == 3 and a rowstride
that is divisible by 4, we were passing invalid
parameters to GL.
Fixes: #3198
|
|\
| |
| |
| |
| |
| |
| | |
Make GtkBuildable vfunc accessor functions private
Closes #3191
See merge request GNOME/gtk!2619
|
| |
| |
| |
| | |
https://gitlab.gnome.org/GNOME/gtk/-/issues/3191
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With the exception of gtk_buildable_get_id(), those are only used
to construct objects from XML descriptions, which is functionality
internal to GTK.
The API is therefore unlikely to be missed, and keeping it internal
means they can no longer unintentionally shadow object methods in
bindings with less namespacing; for example it's currently ambiguous
whether `infoBar.add_child()` refers to gtk_info_bar_add_child() or
gtk_buildable_add_child().
https://gitlab.gnome.org/GNOME/gtk/-/issues/3191
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
GtkBuildable's get_name()/set_name() methods may shadow
GtkWidget's methods. Avoid that by renaming the API to
get_buildable_id()/set_buildable_id(), which also reflects
the name of the XML attribute the API refers to.
https://gitlab.gnome.org/GNOME/gtk/-/issues/3191
|
|\ \
| |/
|/|
| |
| |
| |
| | |
gl: Fix RGB uploads
Closes #3194
See merge request GNOME/gtk!2620
|
| |
| |
| |
| |
| | |
Reset GL_UNPACK_ALIGNMENT to its initial value of 4 after
changing it for a glTexImage2D call.
|
| |
| |
| |
| |
| |
| |
| | |
I don't really know what to say, other than:
OpenGL is terrible
Fixes: #3194
|
|\ \
| | |
| | |
| | |
| | | |
columnview: Simplify column constructors
See merge request GNOME/gtk!2622
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
Drop gtk_column_view_column_new_with_factory and
just make gtk_column_view_column_new accept a
nullable factory. This follows what we've been
doing elsewhere.
Update all callers.
|
|\ \
| |/
|/|
| |
| |
| |
| | |
Wip/carlosg/for master
Closes #3125 and #3121
See merge request GNOME/gtk!2621
|
| |
| |
| |
| | |
This is now only toggled around, may be cleaned up.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The priv->in_button state that used to be relied upon for pointer
events has been reduced over time to a broken state, since the button
does not track crossing events anymore.
Make the coordinate-based checks apply for pointer events too, besides
touch events. This fixes GtkButton mistakenly emitting ::clicked with
pointer button releases outside the widget.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/3121
|
| |
| |
| |
| |
| | |
We still want the drag gesture (and text selection) to work. Avoid claiming
the gesture early, like it's done in the pointer case.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Claiming early makes the contents unable to react to the touch press
event. Do this on GtkGestureDrag::update past a threshold, so the
child widget(s) can claim before the scrolledwindow does.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/3125
|
|/
|
|
|
|
| |
This API is kinda stuck in the GdkEvent days, we now negotiate ownership
of the input sequence via GtkGestures. Remove it as it reflects a way to
work that was not exactly accurate and it will turn plainly wrong soon.
|
|\
| |
| |
| |
| | |
Fix uploads of textures in GLES (and make texture uploads better)
See merge request GNOME/gtk!2616
|
| |
| |
| |
| |
| |
| | |
There is nothing really special about this code, its just a helper for
uploading pixel data to opengl, and we're not really in the business
of doing opengl-specific helper functions.
|
| |
| |
| |
| |
| |
| | |
Do custom uploads rather than using gdk_cairo_surface_upload_to_gl(),
because this way we avoids a roundtrip (memcpy and possibly conversion)
to the cairo image surface format.
|
| |
| |
| |
| |
| |
| |
| |
| | |
The gdk-pixbuf non-rgba format can be directly uploaded without
conversion.
The rgba format needs alpha premultiplication though, which is not
supported by GL during upload.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
GLES doesn't support the GL_BGRA + GL_UNSIGNED_INT_24_8 hack that
we use on desktop OpenGL to upload textures directly in the cairo
pixel format. This adds the required conversions to all the places
that currently need it.
We also add a data_format to the internal gdk_gl_context_upload_texture()
function to make it clearer what the format are. Currently it is always
the cairo image surface format, but eventually we want to support other
formats so that we can avoid some of the unnecessary conversions we do.
Also, the current gdk_gl_context_upload_texture() code always converts
to a cairo format and uploads that like we did before. Later commits
will allow this to use other upload formats that gl supports to avoid
conversions.
|
| |
| |
| |
| |
| |
| |
| | |
This is the default OpenGL format, and in fact the only pixel format
that GLES supports uploading as. Actually, the premultiplied part is
really just about how we use the textures, but all textures in GTK
are premultiplied.
|
| |
| |
| |
| | |
We only have one implementation, so why do all this vfunc work?
|
|\ \
| | |
| | |
| | |
| | | |
Wip/baedert/for master
See merge request GNOME/gtk!2617
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
If we just parse a color, like image(#FFF), avoid allocating the
GPtrArray to store images. This happens in Adwaita for background images
of backdrop buttons. We save around 70 GPtrArrays this way.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
6 is still plenty according to my market research.
Should help with #2624
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
That used to generate a critical error message.
Also free() the data.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
Differentiate between scale_x and scale_y. This works better for e.g.
transform nodes using scaleX().
|
| |/
| |
| |
| | |
We should do this everywhere, but this is a start.
|
|\ \
| |/
|/|
| |
| |
| |
| | |
Matthiasc/for master
Closes #3180, #3178, and #3179
See merge request GNOME/gtk!2618
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Just always tell the title and cell widgets to
clip their children to the right size. Otherwise
we risk things getting out of sync and unintended
overdraw.
Fixes: #3179
|
| |
| |
| |
| |
| |
| |
| |
| | |
We were not handling the fixed_width quite right,
and that was causing screaming from the GTK size
allocation machinery.
Fixes: #3178
|
| |
| |
| |
| |
| |
| |
| | |
When sorting a cell into the place its already at,
we were triggering criticals. Avoid that.
Fixes: #3180
|
|\ \
| |/
| |
| |
| |
| |
| | |
Matthiasc/for master
Closes #3188
See merge request GNOME/gtk!2612
|
| |
| |
| |
| |
| |
| |
| |
| | |
The centered layout of the font previews don't look appealing
and make it harder to judge the relative width and weight of
the individual styles.
Fixes: #3188
|
| |
| |
| |
| |
| |
| |
| |
| | |
In gtk_tree_view_build_tree with recurse=TRUE, the TEST_EXPAND_ROW
signal might invalidate the child iterator. Getting the iterator after
the signal (instead of before) fixes the issue.
Fixes https://gitlab.com/inkscape/inkscape/-/issues/1879
|
| | |
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Adwaita: osd spinbutton specificity bump
Closes #2769
See merge request GNOME/gtk!2610
|
| |/
| |
| |
| |
| |
| |
| | |
- mimic the peculiar selector from the normal style onto osd to
override.
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/2769
|
|\ \
| |/
|/|
| |
| | |
gestures: Make claiming button release work
See merge request GNOME/gtk!2576
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When claiming a sequence in a gesture signal handler,
the expected result is that GtkGesture::handle-event
returns TRUE, causing the event to not be propagated
further.
This doesn't work for button release events, since
gtk_gesture_handle_event does the following:
add point
emit ::update
remove point
check claimed status
The ::update signal is where the application code
claims the sequence. But removing the point purges
the sequence from the gestures memory, so checking
the claimed status returns FALSE.
This patch fixes things to behave as expected, by
checking the claimed status before removing the point.
|
|\ \
| | |
| | |
| | |
| | | |
Adwaita: Improve columnview styling
See merge request GNOME/gtk!2608
|
| | |
| | |
| | |
| | | |
This should be available without .data-table.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Move padding from parent row to child cell.
- Align horizontal sizing of cell with header button.
- Properly support GtkColumnView:show-column-separators.
- Change cell height with and without .data-table.
|