summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * window: Don't mark widget prematurely as has-focusMatthias Clasen2023-04-211-1/+1
| | | | | | | | | | | | has-focus is defined is-focus && toplevel::is-active. We were forgetting to look at is_active when handling focus widget changes.
| * gtk: Improve documentation on returned nodes for snapshotMarco Trevisan (Treviño)2023-04-212-1/+11
| | | | | | | | Closes: #5747
| * openuriportal: Detect if the interface isn't thereMatthias Clasen2023-04-211-0/+6
| | | | | | | | | | | | | | | | | | Check the portal version number before trying to use it. Most importantly, this will detect the case where the interface isn't supported at all, since the proxy will report a version of 0 in that case. Fixes: #5733
| * printunixdialog: Remove a redundant style classAlexander Mikhaylenko2023-04-211-3/+0
| | | | | | | | | | | | .view does absolutely nothing in Default style since the whole box is covered with a GtkNotebook which has its own background, and adds an unwanted background onto the tab strip in Adwaita.
| * gtk/dialogs: Destroy the window promptly on finish async functionMarco Trevisan (Treviño)2023-04-214-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | Some bindings (GJS!) could add temporary references to the GAsyncResult argument that we return, and thus to the GTask, which may cause the dialog not to close when the finish function is called (but at garbage collection instead!). To prevent this, just manually destroy the window (by removing the task data), so that we are not bound to the GTask lifetime anymore. Closes: https://gitlab.gnome.org/GNOME/gtk/-/issues/5741
| * filechooserentry: Plug a memory leakMatthias Clasen2023-04-211-0/+3
| |
| * filechooserentry: Make filtering work againMatthias Clasen2023-04-211-12/+14
| | | | | | | | | | | | | | | | We need to look at the filchooser::filtered-out attribute to know which files the filesystem model has filtered away. Fixes: #5743
| * textview: Reset press counter if double/triple clicking on a different lineCarlos Garnacho2023-04-211-0/+20
| | | | | | | | | | | | | | | | | | | | If we click close enough between lines, and with the maximum distances applied by GtkGestureClick we could jump between lines when handling double/triple click for word/line selection. Ensure that the whole operation stays in the same line and reset the gesture/counter if we do move between lines, so we start from scratch in the new line.
| * scalebutton: fix orientation not applied to scaleG.Willems2023-04-211-0/+39
| |
| * scalebutton: fix CSS name in documentationG.Willems2023-04-211-2/+8
| |
| * scrolledwindow: Avoid a criticalMatthias Clasen2023-04-211-3/+2
| | | | | | | | | | | | When setting the child property to NULL, we also need to unset auto_added_viewport, to avoid triggering a critical when setting it again.
| * gtk-demo: Add a keywordMatthias Clasen2023-04-211-1/+1
| | | | | | | | Make the demo using the 'bluroverlay' come up when you type 'blur'.
| * gesture stylus: Fix conditionMatthias Clasen2023-04-211-1/+1
| | | | | | | | | | | | | | Now that the paint demo lets us test this, it has become apparent that this condition is wrong, and we don't get the expected events if stylus-only is FALSE.
| * gtk-demo: Work without stylusMatthias Clasen2023-04-211-2/+4
| | | | | | | | | | | | In the paint demo, don't assume that the event backlog contains pressure. It won't, if we are working with a plain old mouse.
| * gtk-demo: Test stylus-only modeMatthias Clasen2023-04-211-6/+22
| | | | | | | | | | Add a checkbutton to toggle the stylus-only mode of GtkGestureStylus, so we can test this.
| * range: Fix a copy-paste errorMatthias Clasen2023-04-211-1/+1
| | | | | | | | | | This was showing up as the alpha popup in the color editor not being positioned correctly.
| * gestureclick: Use drag threshold for updatesMatthias Clasen2023-04-211-8/+4
| |
| * gestureclick: Don't use threshold for touchMatthias Clasen2023-04-211-2/+6
| | | | | | | | | | | | | | | | When determining double-clicks, don't use the distance threshold for touch events. It is very hard to double touch reliably within a few pixels of the same position. Fixes: #5580
| * gtkpopover: Move GTK grabs to map/unmapCarlos Garnacho2023-04-211-8/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Typically, a popover gets mapped when shown and unmapped when hidden. A situation there that breaks is where the popover gets recursively unmapped/unrealized when its root is destroyed. In that situation, the popover does however unmap (without being hidden first), moving the GTK grab from show/hide to map/unmap will handle the previous situations, plus this one. Fixes things being unclickable if e.g. a modal dialog got a popover popped up, then got closed via Alt-F4. Closes: https://gitlab.gnome.org/GNOME/gtk/-/issues/5730
| * inspector: Redo the actions listMatthias Clasen2023-04-212-37/+249
| | | | | | | | | | Make the actions list implement GtkActionObserver for the muxer case, and make updates work.
| * inspector: Simplify the action editorMatthias Clasen2023-04-212-81/+22
| | | | | | | | | | No need to listen for changes, the actions list code will do so and tell us to update.
| * inspector: Add ActionHolder::changedMatthias Clasen2023-04-212-0/+18
| | | | | | | | | | We will use this signal to communicate action changes to the action list widgetry.
| * inspector: CosmeticsMatthias Clasen2023-04-211-14/+10
| | | | | | | | | | Make the variant editor use a checkbutton instead of a togglebutton.
| * actionmuxer: Add a preconditionMatthias Clasen2023-04-211-0/+2
| | | | | | | | | | This helps with debugging the inspectors action handling.
| * inspector: Be more carefulMatthias Clasen2023-04-211-4/+10
| | | | | | | | | | Tweak the variant-editor code to handle some cases more explicitly.
| * inspector: Plug a memory leakMatthias Clasen2023-04-211-0/+2
| |
| * inspector: Be safer when handling actionsMatthias Clasen2023-04-212-11/+30
| | | | | | | | | | | | Those query apis are serious about not ignoring their return value, and may not set their our arguments to anything if they return FALSE.
| * actionmuxer: Make the compiler warnMatthias Clasen2023-04-211-1/+1
| | | | | | | | | | | | Warn when the boolean return isn't used, since we may not initialize the out arguments in the FALSE case (see the previous commits).
| * textview: Handle a return valueMatthias Clasen2023-04-211-1/+2
| |
| * inspector: fix crash caused by uninitialized GVariantNelson Benítez León2023-04-211-8/+6
| | | | | | | | | | | | | | | | | | | | we were not checking the return gboolean of gtk_action_muxer_query_action() which was returning FALSE for the crash case, meaning it didn't set the passed in GVariant, but we were still using it as it was non-null. Fixes #5729
| * mediacontrols: Add tooltip text to play buttonMaximiliano Sandoval R2023-04-213-2/+12
| | | | | | | | This makes the button accessible.
| * a11y: Map GTK_ACCESSIBLE_ROLE_ALERT_DIALOG to ATSPI_ROLE_ALERTLukáš Tyrychtr2023-04-211-1/+1
| | | | | | | | | | By doing this, alert dialogs will be read automatically, or at least they should be, because a screen reader know that these are special.
| * expander: Fix the css docsMatthias Clasen2023-04-211-4/+4
| | | | | | | | | | | | | | The docs were not matching reality since the css node names were changed in 6d20fe0b. Fixes: #5723
| * rendernodepaintable: Preserve aspect ratio in snapshot()Matthias Clasen2023-04-211-2/+2
| | | | | | | | This is the better fix.
| * node-editor: Improve the scalingMatthias Clasen2023-04-212-10/+27
| | | | | | | | | | We only want to scale the main rendering, not whats shown in the sidebar. Also, make the scale logarithmic.
| * tooltipwindow: Cast the correct objectBenjamin Otte2023-04-211-1/+1
| | | | | | | | the tooltipwindow is in the userdata.
| * Documentation corrections for GtkTextIterCam Cook2023-04-211-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | method | current | suggestion | |------------------------------------------------------------------------------------------------------------|---------------------------------------------------------------|-----------------------------------------------------------------| | [backward_visible_cursor_position](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3785) | "Moves @iter forward to the previous visible cursor position" | "Moves @iter backward to the previous visible cursor position." | | [get_offset](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L595) | "Use [method@Gtk,TextBuffer.get_iter_at_offset]" | "Use [method@Gtk.TextBuffer.get_iter_at_offset]" | | [starts_tag](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L1201) | "returns %TRUE, [method@Gtk.TextIter.has_tag" | "returns %TRUE, [method@Gtk.TextIter.has_tag] " | | method | current | suggestion | |--------------------------------------------------------------------------------------------------------|-----------------------------------------------------|-----------------------------------------------------------| | [backward_cursor_position](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3715) | "Like gtk_text_iter_forward_cursor_position()" | "Like [method@Gtk.TextIter.forward_cursor_position]" | | [backward_find_char](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L4483) | "Same as gtk_text_iter_forward_find_char()" | "Same as [method@Gtk.TextIter.forward_find_char]" | | [backward_search](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L5295) | "Same as gtk_text_iter_forward_search()" | "Same as [method@Gtk.TextIter.forward_search]" | | [backward_sentence_starts](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3611) | "Calls gtk_text_iter_backward_sentence_start()" | "Calls [method@Gtk.TextIter.backward_sentence_start]" | | [backward_visible_word_starts](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3421) | "Calls gtk_text_iter_backward_visible_word_start()" | "Calls [method@Gtk.TextIter.backward_visible_word_start]" | | [backward_word_starts](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3345) | "Calls gtk_text_iter_backward_word_start()" | "Calls [method@Gtk.TextIter.backward_word_start]" | | [forward_sentence_ends](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3591) | "Calls gtk_text_iter_forward_sentence_end()" | "Calls [method@Gtk.TextIter.forward_sentence_end]" | | [forward_to_end](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L4131) | "gtk_text_iter_get_char() called on" | "[method@Gtk.TextIter.get_char] called on" | | [forward_visible_word_ends](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3403) | "Calls gtk_text_iter_forward_visible_word_end()" | "Calls [method@Gtk.TextIter.forward_visible_word_end]" | | [forward_word_ends](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3327) | "Calls gtk_text_iter_forward_word_end()" | " Calls [method@Gtk.TextIter.forward_word_end]" | | [is_end](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L1664) | "gtk_text_iter_is_end() is the most efficient" | "[method@Gtk.TextIter.is_end] is the most efficient" | | [set_line_index](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3900) | "Same as gtk_text_iter_set_line_offset()" | "Same as [method@Gtk.TextIter.set_line_offset]" | | [set_visible_line_index](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3987) | "Like gtk_text_iter_set_line_index()" | "Like [method@Gtk.TextIter.set_line_index]" | | [set_visible_line_offset](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3946) | "Like gtk_text_iter_set_line_offset()" | "Like [method@Gtk.TextIter.set_line_offset]" |
| * Documentation corrections for GtkTextIterCam Cook2023-04-211-17/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | method | current | suggestion | |------------------------------------------------------------------------------------------------------------|---------------------------------------------------------------|-----------------------------------------------------------------| | [backward_visible_cursor_position](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3785) | "Moves @iter forward to the previous visible cursor position" | "Moves @iter backward to the previous visible cursor position." | | [get_offset](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L595) | "Use [method@Gtk,TextBuffer.get_iter_at_offset]" | "Use [method@Gtk.TextBuffer.get_iter_at_offset]" | | [starts_tag](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L1201) | "returns %TRUE, [method@Gtk.TextIter.has_tag" | "returns %TRUE, [method@Gtk.TextIter.has_tag] " | | method | current | suggestion | |--------------------------------------------------------------------------------------------------------|-----------------------------------------------------|-----------------------------------------------------------| | [backward_cursor_position](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3715) | "Like gtk_text_iter_forward_cursor_position()" | "Like [method@Gtk.TextIter.forward_cursor_position]" | | [backward_find_char](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L4483) | "Same as gtk_text_iter_forward_find_char()" | "Same as [method@Gtk.TextIter.forward_find_char]" | | [backward_search](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L5295) | "Same as gtk_text_iter_forward_search()" | "Same as [method@Gtk.TextIter.forward_search]" | | [backward_sentence_starts](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3611) | "Calls gtk_text_iter_backward_sentence_start()" | "Calls [method@Gtk.TextIter.backward_sentence_start]" | | [backward_visible_word_starts](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3421) | "Calls gtk_text_iter_backward_visible_word_start()" | "Calls [method@Gtk.TextIter.backward_visible_word_start]" | | [backward_word_starts](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3345) | "Calls gtk_text_iter_backward_word_start()" | "Calls [method@Gtk.TextIter.backward_word_start]" | | [forward_sentence_ends](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3591) | "Calls gtk_text_iter_forward_sentence_end()" | "Calls [method@Gtk.TextIter.forward_sentence_end]" | | [forward_to_end](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L4131) | "gtk_text_iter_get_char() called on" | "[method@Gtk.TextIter.get_char] called on" | | [forward_visible_word_ends](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3403) | "Calls gtk_text_iter_forward_visible_word_end()" | "Calls [method@Gtk.TextIter.forward_visible_word_end]" | | [forward_word_ends](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3327) | "Calls gtk_text_iter_forward_word_end()" | " Calls [method@Gtk.TextIter.forward_word_end]" | | [is_end](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L1664) | "gtk_text_iter_is_end() is the most efficient" | "[method@Gtk.TextBuffer.is_end] is the most efficient" | | [set_line_index](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3900) | "Same as gtk_text_iter_set_line_offset()" | "Same as [method@Gtk.TextBuffer.set_line_offset]" | | [set_visible_line_index](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3987) | "Like gtk_text_iter_set_line_index()" | "Like [method@Gtk.TextBuffer.set_line_index]" | | [set_visible_line_offset](https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtktextiter.c#L3946) | "Like gtk_text_iter_set_line_offset()" | "Like [method@Gtk.TextBuffer.set_line_offset]" |
| * inspector: Update some misc info rowsMatthias Clasen2023-04-211-0/+6
| |
| * gsk/gl/renderjob: Decompose matrix for 3D transformsGeorges Basile Stavracas Neto2023-04-211-17/+15
| | | | | | | | While this can be more expensive, it's also correct.
| * inspector: Improve display of pathsMatthias Clasen2023-04-211-7/+0
| | | | | | | | | | | | The values in the path section are long and generally ellipsized. It does not make sense to reserve extra space that the labels don't need.
| * docs: Improve GtkLabel renderingBilal Elmoussaoui2023-04-211-3/+3
| | | | | | | | By adding some missing links & avoid the browser from rendering the entities as their equivalent symbols
| * listitem: Fix a notification problemMatthias Clasen2023-04-211-1/+1
| | | | | | | | | | We were notifying ::item when ::child is changed. Oops
| * a11y: Set ATSPI_STATE_SHOWING for all widgets, not only for windowsLukáš Tyrychtr2023-04-211-1/+2
| | | | | | | | | | | | | | | | According to the at-spi2 docs, for a widget to be considered visible, it needs both the showing and visible states. Many applications rely on that, for example the flat review functionality of Orca. this fixes #5194
| * Remove wrong annotation for GdkToplevel::compute-sizeEmmanuele Bassi2023-04-211-5/+6
| | | | | | | | | | | | The size argument is passed to the signal by the GDK surface machinery, as is: it's not going to be allocated by the caller (since it's a signal), and it's not an out argument.
| * magnifier: Correct position of areaMatthias Clasen2023-04-211-4/+18
| | | | | | | | | | | | | | The widget paintable uses the widgets bounds as intrinsic size, so we need to offset from that to the allocation, which is what the coordinates are relative to.
| * texthandle: Correct placement of handlesMatthias Clasen2023-04-211-3/+14
| | | | | | | | | | | | | | | | | | | | Text handles had the same problem as popovers. They were interpreting their pointing-to rectangle relative to the widgets bounds, when it is meant to be relative to the widgtets allocation. While we touch this code, rewrite it to use gtk_widget_compute_point.
| * popover: Correct placement of popoversMatthias Clasen2023-04-211-5/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When we don't have a pointing-to rectangle, we want to place the popover wrt to the parents bounds. But if we have a pointing-to rectangle, it is relative to the widgets allocation, which is different from the bounds. We were not handling the second case correctly, leading to context menus in the text view being mispositioned by the widgets CSS padding. While we are touching this code, rewrite it to handle transforms. Fixes: #5695
| * docs: Improve markup for keysMatthias Clasen2023-04-217-41/+58
| | | | | | | | | | Consistently use <kbd>x</kbd> to render keys in the docs and use + for key combinations.
| * docs: Some updatesMatthias Clasen2023-04-211-5/+8
| | | | | | | | Fix some links ot point to docs.gtk.org.
View Lorry Controller Status