| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Modern icon themes don't ship .icon files anyway.
|
|
|
|
| |
This functionality is not used at all in modern icon themes.
|
|
|
|
|
| |
We don't need it anymore, now that the non-standard stock icons
are using resources.
|
|
|
|
|
| |
They will no longer be available as named icons when we
drop the builtin icons.
|
|
|
|
|
| |
This will allow us to remove the builtin icon cache in the future
while keeping the deprecated stock icons working.
|
|
|
|
|
|
| |
We're going to require a complete icon theme, and we have
a test that checks for all the icons we use, so there is
no need to include all these fallback icons.
|
|
|
|
|
|
|
|
|
| |
When we switched the default for gtk-update-icon-cache to
not include image data, we should have thought about the
builtin icons. For them, we rely on image data being included.
This made the notify test fail in gnome-continuous, where we
build from git and always regenerate the builtin cache.
|
|
|
|
|
| |
We want to get rid of these, but as long as we still have them,
make sure they work.
|
|
|
|
|
|
|
|
|
|
| |
This pushes the initialization of is_svg to an earlier point
when the GtkIconInfo is created. This is needed because an icon
info doesn't necessarily always have a filename that we can later
extract the suffix from. For instance, builtin icons have NULL
filename.
https://bugzilla.gnome.org/show_bug.cgi?id=721895
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Copy the icons in stock_icons accordingly, so that the built-in icons can
be found by GTK, as it seems that not all of them are built into
gtkbuiltincache.h.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
We want to have the "-gtk-" prefix for our custom CSS properties. But
we also want to parse names starting with a "-" as style properties.
So make sure that "-gtk-" is treated like a normal property and we emit
errors when somebody uses it wrong.
This is to catch errors with people typing
-gtk-iconsource: none;
instead of the correct
-gtk-icon-source: none;
|
|
|
|
|
|
| |
This reverts commit 0f4751c08e22a4f45d58e2368e4ae82df407d330.
This causes warnings from the notebook and combobox code.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We want to make sure that the submenu action is changed back to FALSE
_after_ the menu item has been activated. This prevents the menu
teardown handler from deleting the menu item before it can be activated.
Unfortunately, GtkMenuShell emits "hide" before the item activation.
This is probably done to prevent the application from doing things like
showing dialogs when the menu is still holding the grab.
In the case where we are doing an activate, set a boolean flag on each
of the open menus (following the parent stack) indicating that we'll be
emitting another signal soon (selection done). If that flag is set, we
defer the setting of the submenu action until we receive the second
signal.
https://bugzilla.gnome.org/show_bug.cgi?id=729820
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
That test is not working anymore by design since commit 57c4f01e.
It was introduced pre-3.0.0 in commit 12d6b588 and the feature was never
utilized. So it seems safe to just remove the test.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
When duplicating the icon_info, we forgot to set is_svg. This meant that
any application that used gtk_icon_info_load_icon_async wouldn't have
is_svg set properly.
This fixes blurry icons in the gnome-shell app picker.
|
| |
|
| |
|
|
|
|
|
| |
As we are using Adwaita by default on all platforms, do the same for
GtkInspector, to be consistent with the rest of GTK+.
|
|
|
|
|
|
| |
Set the .top, .left, etc css classes and render the background
of the border windows.
Change the reftest implementation accordingly.
|
|
|
|
|
|
|
| |
TextView border windows are internal windows used to draw on the gutter
of the textview (e.g. line numbers). The test uses the gmodule hook to
programmatically draw on the border-windows at each side of the textview
and compares the result with 3x3 grid of labels.
|
|
|
|
|
|
| |
add a reftest that checks GtkTextView text margin property comparing
with the normal margin added to the widget (they are the same when there
is nothing drawn in the gutter like line numbers etc).
|
| |
|
| |
|
| |
|
|
|
|
| |
Otherwise the icontheme test fails in continuous.
|
|
|
|
| |
This reverts commit ceed0ee7032810476e1563884a7cb04c8fad8ce8.
|
|
|
|
|
|
|
|
| |
Previously GtkMenuTracker tried to access "gtk_menu_tracker_item_get_is_visible",
but the correct getter is "_gtk_menu_tracker_item_is_visible". This commit
corrects this reference
https://bugzilla.gnome.org/show_bug.cgi?id=731430
|
|
|
|
|
| |
Now that we don't include the image data by default anymore,
lets add an option that does it.
|
|
|
|
|
|
| |
We already know based on the suffix of the filename.
https://bugzilla.gnome.org/show_bug.cgi?id=721895
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since large images are in the icon cache, and apps don't tend to use that
many icons anymore, simply don't include image data and instead make apps
load files from disk. Additionally, since they're stored in GdkPixbuf data,
that means that we have to first convert them either to a cairo_surface_t,
which requires converting pixel data to be premulitplied, or an OpenGL
texture, which requires a whole GPU upload anyway.
So, even with the icon cache, the goal of icons through zero-copy, mmap()'d
data from disk just isn't doable with the icon cache format we have. The
icon cache on my disk is nearing 100MB, since we include a bunch of
high-resolution application icons, that I doubt would be used by apps at all.
Removing this inefficient pixel data makes memory usage for all applications
go down, with no speed loss.
The icon cache also, however, has an index of what icons are in each folder,
which prevents a readdir() and allows GTK+ to know what icon is where without
having to do a bunch of stat(); calls. Keeping this data is good for GTK+,
so we should still keep the index.
It doesn't make sense to remove any code for mapping pixel data from the icon
cache. There's a plan in the works to have a symbolic icon cache that does
pixel math on 16x16 icons to prevent slow SVG rendering. 16x16 pixels are
fairly small, and such images are flat colors, which should compress easily,
so the icon cache would be worthwhile here. So let's keep the code around
in preparation for that case.
https://bugzilla.gnome.org/show_bug.cgi?id=721895
|
|
|
|
|
|
| |
We want to have .top etc also on the notebook frame, not only on
the header frame.
The patch includes a reftest by Benjamin.
|
|
|
|
|
|
|
|
|
|
| |
This changes makes svg icons go through the same scale calculation
code as png icons. As a consequence, an svg that is put into the
32x32 directory will actually be loaded at size 32, even if it
gets requested at a bigger size. This will let us avoid giant
spinners.
https://bugzilla.gnome.org/show_bug.cgi?id=731658
|
|
|
|
|
| |
This test is focused on svgs, and how we scale them when
loading.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
- added slider assets for scales with marks
- experimental touch friendly fine-tune mode, grow the trough istead
of shrinking the slider
|