| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
- initial stab at simplifying buttons
|
|
|
|
| |
We can't remove() a child widget that wasn't already add()ed, of course.
|
|
|
|
|
|
| |
The file chooser button manually manages the memory of
data in its model, so it needs to explicitly free the
rows.
|
|
|
|
| |
GCs have been dead for a long time.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
We haven't had a GtkWindow::frame-event since the
linux-fb backends demise.
|
| |
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=741633
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=741633
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Both AC_TRY_COMPILE and AC_LANG_PROGRAM put code passed to their second
arguments to the body of the main function. This means that we cannot
and should not declare functions there, or we end up checking whether
the compiler support nested functions instead of whether a compiler or
linker flag is supported.
GCC supports nested functions and tests succeed. Clang doesn't support
nested functions, so tests fail and -fvisibility=hidden won't be used.
This means that functions which are not intended to be used by other
programs, such as gtk_menu_tracker*, gtk_action_observ*,
gtk_menu_muxer_*, become global symbols with default visibility.
GNOME Shell has a private library libgnome-shell-menu.so, which also has
symbols gtk_menu_tracker*, gtk_action_observ*, gtk_menu_muxer_* that are
intended to be used by GNOME Shell itself. When GNOME Shell still used
Autotools build system, the executable gnome-shell explicitly linked to
libgnome-shell-menu.so, so the linker loaded libgnome-shell-menu.so
before libgtk-3.so.0 and GNOME Shell used correct symbols from its
private library.
However, after GNOME Shell switched to Meson build system, gnome-shell
executable no longer lists libgnome-shell-menu.so as its dependency.
Even if we adds it to the build file, it won't be listed in DT_NEEDED of
gnome-shell because Meson uses -Wl,--as-needed by default. This causes
the runtime linker to load libgtk-3.so.0 before libgnome-shell-menu.so
and symbols gtk_menu_tracker*, gtk_action_observ*, gtk_menu_muxer_* are
bound to libgtk-3.so.0 instead of libgnome-shell-menu.so. GNOME Shell
hangs when opening more than one window because it uses functions from
the wrong library.
This problem is already fixed in OpenBSD ports. The article describing
it can be found on OpenBSD Journal with this link:
https://undeadly.org/cgi?action=article;sid=20170930133438
https://bugzilla.gnome.org/show_bug.cgi?id=791943
|
|
|
|
|
|
| |
Signed-off-by: Arnaud Rebillout <elboulangero@gmail.com>
https://bugzilla.gnome.org/show_bug.cgi?id=791710
|
|
|
|
|
|
|
|
| |
Mostly spaces.
Signed-off-by: Arnaud Rebillout <elboulangero@gmail.com>
https://bugzilla.gnome.org/show_bug.cgi?id=791710
|
|
|
|
|
|
| |
Signed-off-by: Arnaud Rebillout <elboulangero@gmail.com>
https://bugzilla.gnome.org/show_bug.cgi?id=791710
|
|
|
|
|
|
| |
Signed-off-by: Arnaud Rebillout <elboulangero@gmail.com>
https://bugzilla.gnome.org/show_bug.cgi?id=791710
|
|
|
|
|
|
| |
Signed-off-by: Arnaud Rebillout <elboulangero@gmail.com>
https://bugzilla.gnome.org/show_bug.cgi?id=791710
|
|
|
|
|
|
| |
Signed-off-by: Arnaud Rebillout <elboulangero@gmail.com>
https://bugzilla.gnome.org/show_bug.cgi?id=791710
|
|
|
|
|
|
| |
Signed-off-by: Arnaud Rebillout <elboulangero@gmail.com>
https://bugzilla.gnome.org/show_bug.cgi?id=791710
|
|
|
|
|
|
| |
Signed-off-by: Arnaud Rebillout <elboulangero@gmail.com>
https://bugzilla.gnome.org/show_bug.cgi?id=791710
|
|
|
|
|
|
| |
Signed-off-by: Arnaud Rebillout <elboulangero@gmail.com>
https://bugzilla.gnome.org/show_bug.cgi?id=791710
|
|
|
|
|
|
| |
meta-pick of commit c1573a1fda7c3b917b6809795b9668629fe58883: the
variable gdk_window is used in a check, but we may as well use it again
to avoid calling _gtk_widget_get_window() again unnecessarily.
|
| |
|
|
|
|
| |
as per commit b4b9aa1e5fab6a1f8c27b768813ab4ed04f3cd6f
|
|
|
|
|
|
| |
Signed-off-by: Arnaud Rebillout <elboulangero@gmail.com>
https://bugzilla.gnome.org/show_bug.cgi?id=791710
|
|
|
|
|
|
| |
Putting a combobox in an expander was causing the combo arrow
to go sideways. Increase the specificity with which we address
the expander arrow to avoid that.
|
| |
|
| |
|
|
|
|
|
| |
Starting to type should focus the search entry and start
a search.
|
|
|
|
|
| |
These functions have been removed in master, and their
replacements are already available here.
|
|
|
|
|
| |
Don't refer to the font-name property in docs either, and
don't use deprecated API internally.
|
|
|
|
|
| |
It has long been redundant with the GtkFontChooser::font
property.
|
|
|
|
| |
We can instead use the GtkFontChooser::font property.
|
|
|
|
|
|
|
| |
The change in the previous patch should only be applied when the Range
is oriented horizontally.
https://bugzilla.gnome.org/show_bug.cgi?id=737175
|
|
|
|
|
|
|
|
|
|
|
|
| |
Users expect, & previous patches have tried to assure, that scrolling up
over a horizontal Range will cause the value to increase & vice-versa.
But the path using directions was still negating the delta & decreasing
the value on scrolling up. This could be seen on Win32 or X without XI2.
So, only negate the delta when scrolling down (or left), not up, so that
scrolling up (or right) will make the value increase for any event type.
https://bugzilla.gnome.org/show_bug.cgi?id=737175#c5
|
|
|
|
|
|
|
| |
The only time a style-updated indicates we need
to reload fonts is when it is synthesized by GtkSettings
in response to a fontconfig timestamp change, but
we are listening to those already, anyway.
|
|
|
|
|
|
|
| |
Stash the DESKTOP_AUTOSTART_ID env var in a constructor,
before any threads have been created.
https://bugzilla.gnome.org/show_bug.cgi?id=790963
|
|
|
|
|
|
| |
This is just a bandaid solution to make scale 3 work.
If people seriously want to go for scales larger than
that, we need a better solution.
|
|
|
|
| |
Might as well allow this, for 'large scale testing'.
|
|
|
|
|
|
| |
No need to keep complaining about this.
https://bugzilla.gnome.org/show_bug.cgi?id=791650
|
|
|
|
|
|
| |
This reverts commit 492469a94af35c2b102bcf7f07046ef2d09b2b3d.
People have been reporting missing invalidations with this change.
|
|
|
|
|
|
| |
gtk_widget_real_style_updated()"
This reverts commit 7e253f4bd3977a67cf7040ce11e24b9d06100f6a.
|