| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=752965
|
|
|
|
|
|
| |
- make some room around the sidebar icons
https://bugzilla.gnome.org/show_bug.cgi?id=752960
|
|
|
|
|
| |
Just to demonstrate the capability, not because this is
excellent UI.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we started adding a persistent Computer item,
all the code related to the view modes became obsolete,
since the view is never empty anymore. So, drop this
dead code and use the plain stack to manage the empty
search results view.
Also, this patch fixed a very annoying keyboard navigation
issue where we couldn't go from the On This Computer to Networks
lists, because they were two separate widgets. Merge the two
lists into a single one, and update headers accordingly.
|
|
|
|
|
| |
It is needed to hook up the finalize method, since
it's overriden manually.
|
|
|
|
|
|
|
|
| |
The places sidebar rows' labels were missing a proper
xalign, which caused the labels to keep shaking while
the sidebar was resized.
Fix that by setting the label's xalign to 0.
|
|
|
|
|
|
|
| |
The GFile containing the Computer item was not
properly dereferenced, so plug that leak by both
dereferencing it and adding some reference management
on GtkPlacesViewRow.
|
|
|
|
|
|
|
|
|
|
|
| |
GtkPlacesView widget manages persistent locations,
factoring out GtkPlacesSidebar functionality.
It, however, does not completely shows all sidebar
locations, since Computer is still missing.
Add a Computer item, adjusting some internal behavior
to make that possible.
|
|
|
|
|
|
|
| |
It is distracting, not relevant and too space
consuming.
Remove the network addresses label.
|
|
|
|
|
|
|
|
| |
The doc for gtk_places_view_get_search_query was being
set twice, while gtk_places_view_set_search_query was
never set.
Fix that by correcting the wrong getter documentation.
|
|
|
|
|
|
|
| |
Use the same explanation of why GtkPlacesSidebar::show-connect-server
was deprecated and its replacements on getter and setter.
Also, fix a mistakenly deprecated function.
|
|
|
|
|
| |
This is useful to verify the monitor information returned by
other backends.
|
|
|
|
|
| |
Don't call it "X display" when we show useful information under
Wayland as well.
|
|
|
|
|
| |
Make gdk_screen_make_display_name() return a likely correct
name for the Wayland socket we are using.
|
|
|
|
|
|
|
|
|
|
|
|
| |
When dealing with selection events, we might see windows from
other screens in the requestor field. The current x11 backend
code fails to wrap these in a foreign GdkWindow, since we
don't have the corresponding GdkScreen anymore. Work around
this by creating such 'foreign screens' on demand. We still
maintain the 1:1 relation between the display and the screen
returned by gdk_display_get_default_screen().
https://bugzilla.gnome.org/show_bug.cgi?id=721398
|
| |
|
|
|
|
|
|
|
| |
GtkCssProvider was using the wrong unref function for GtkCssKeyframe
objects. Funnily, this didn't crash at all, the refcount was at the
same place in the struct - it just didn't free all the memory, causing
valgrind to complain.
|
|
|
|
|
|
|
|
| |
Use the new cairo to NSImage converter function
to set the device scale.
Remove the pixbuf converter function as this was
the last user.
|
|
|
|
|
|
|
| |
Instead of storing the dnd icon as a pixbuf store it
as a cairo surface and transfer the device scale
when converting it to a NSImage. In the pixbuf/stock/named
setters convert to a surface instead (no hidpi support yet)
|
|
|
|
| |
The y axis is reversed on osx
|
|
|
|
|
|
|
|
| |
The shadow will be drawn in the wrong place in those cases so all we can
do is disable it. This fixes double shadows drawn around menus, popups
and tooltips.
https://bugzilla.gnome.org/show_bug.cgi?id=734984
|
|
|
|
|
|
|
|
|
| |
Previous commits removed from places sidebar the code related
to displaying the Computer item, which should be shown when
the sidebar is not displaying the Other Locations item.
Add back the item when the sidebar is not in Other Locations'
mode.
|
|
|
|
| |
Broken by 6d04183c5d6 and 6ac07a2e85ea
|
|
|
|
|
| |
Inform the user that we won't search recursively when searching
in remote locations.
|
|
|
|
|
|
| |
Make GtkSearchHit carry a GFile instead of an uri. Most of the
search engines already have the object around, and converting
to an uri and back is unnecessary extra work.
|
|
|
|
|
| |
This is slow, and causes too much network I/O.
So skip locations that look like they are remote.
|
|
|
|
|
|
|
| |
Add a helper function that says whether a location should be
considered remote. To determine this, we look at the filesystem
type reported by gvfs, and say 'remote' for sftp, webdav, ftp,
nfs and cifs.
|
|
|
|
|
|
| |
We didn't connect to the signals, so we never picked up
any search results from the model engine. Good thing, since
it was returning the wrong thing.
|
|
|
|
|
|
| |
GtkSearchEngineModel was still trying to return uris as hits.
This is not working anymore, we are expected to return GtkSearchHit
structs.
|
|
|
|
|
| |
Failure to do so was causing search to start from the home dir
when the current folder is not represented on the sidebar.
|
|
|
|
|
|
| |
It is a bit pointless to have the file chooser get a uri from an
existing GFile to put in the query, only to have some of the search
engines reconstruct a GFile from it.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
The button is the same in both menu and list mode, so there's no need to
destroy and recreate it.
|
| |
|
|
|
|
| |
The visible check is always FALSE, so no need to keep the code around.
|
|
|
|
|
|
|
| |
... when in menu mode.
Now that we don't have a separator anymore, the box is not needed
anymore.
|
|
|
|
|
|
|
| |
It was a special case and it's not used by themes anymore.
Plus, in the CSS world, if a theme wants a separator, it can just
style the button's border to create one.
|
|
|
|
|
| |
dialog-information was twice in the list of accessible labels
for icon names.
|
|
|
|
|
| |
Selecting a range of rows with Shift-click was accidentally broken
in e6e511eb460d8fcd. Make it work again.
|
|
|
|
|
|
| |
This is necessary to make notebook tab DND work.
https://bugzilla.gnome.org/show_bug.cgi?id=752638
|
|
|
|
|
|
|
|
| |
If a drag ends inside a known window, set the dest_window field
in the drag context. This information is needed to implemented
notebook tab dragging.
https://bugzilla.gnome.org/show_bug.cgi?id=752638
|
|
|
|
|
|
|
|
|
| |
Without properly cleaning up GtkMenu private attach state
(GtkMenuAttachData) when the attached widget is freed, we would end up
with an invalid pointer to a freed widget. Trying to detach from that
widget would cause a segmentation fault.
https://bugzilla.gnome.org/show_bug.cgi?id=752761
|
|
|
|
|
|
|
|
| |
-1 means that we have no specific preference for an initial
fullscreen monitor, and -1 is less than the number of monitors,
so we would end up accessing invalid memory. Prevent that.
https://bugzilla.gnome.org/show_bug.cgi?id=752875
|
| |
|
|
|
|
|
|
|
| |
This changes GTK+ to use gdk_cursor_new_from_name() with the
'standard' css names, instead of GdkCursorType.
https://bugzilla.gnome.org/show_bug.cgi?id=652085
|
|
|
|
| |
Approximate some of the resize cursors with similar cursors.
|