| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
|
|
|
|
|
| |
The function is now safe to use.
https://bugzilla.gnome.org/show_bug.cgi?id=735341
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid crashes when passing an invalid location to a
gtk_text_buffer_get_iter_at_*() function.
A boolean is returned to know if @iter has been set to the exact
location.
Unit tests are added.
https://bugzilla.gnome.org/show_bug.cgi?id=735341
|
| |
|
| |
|
|
|
|
| |
This avoids polluting the installed header with private symbols.
|
|
|
|
|
| |
Test appending text as well as replacing the entire text.
Insert non-ASCII text to verify offsets are correct.
|
|
|
|
|
|
|
|
|
| |
When the search entry is shown, the 'special' nature of
., ~ and / should not trigger the location entry, because
that interrupts the search and is likely not what the
user intended.
https://bugzilla.gnome.org/show_bug.cgi?id=756505
|
|
|
|
|
|
| |
When the entry completion is popped up from a timeout, we may
not have a device. In that case, don't call gdk_device_grab,
do avoid criticals.
|
|
|
|
|
|
|
| |
It seems that gdk_device_get_name() can return NULL.
We should not crash if that happens.
https://bugzilla.gnome.org/show_bug.cgi?id=756625
|
|
|
|
|
|
|
| |
Use the box margin top instead of the label margin top,
so the spinner remains aligned with the header label.
https://bugzilla.gnome.org/show_bug.cgi?id=756568
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=756568
|
|
|
|
|
|
| |
Since other views are not using hover neither
https://bugzilla.gnome.org/show_bug.cgi?id=756568
|
|
|
|
|
|
| |
So it allows a quick way to clear the entry.
https://bugzilla.gnome.org/show_bug.cgi?id=756568
|
|
|
|
|
|
|
|
|
|
| |
Disclosure triangles are usually used pointing down, however
in this case the popover spawns in the upper direction, which
makes it odd looking.
Instead of pointing always down or up, point down when not toggled and
animate a rotation when toggled.
https://bugzilla.gnome.org/show_bug.cgi?id=756568
|
|
|
|
|
|
|
|
| |
Following design guidance, reduce row height and increase
popover height so the user is allowed to see more than 3
rows.
https://bugzilla.gnome.org/show_bug.cgi?id=756568
|
|
|
|
|
|
|
| |
Following the sidebar on commit b0989b190df, improve the way
we check when a drive is external or not.
https://bugzilla.gnome.org/show_bug.cgi?id=756589
|
|
|
|
|
|
| |
This is checked on add_volume inside the loop.
https://bugzilla.gnome.org/show_bug.cgi?id=756589
|
|
|
|
|
|
| |
This is checked on is_removable_volume
https://bugzilla.gnome.org/show_bug.cgi?id=756589
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the change to use GtkPlacesView we don't want to show
internal storage on the sidebar.
In our case we were checking for drive_can_eject and
drive_is_media_removable.
However for some external hard drives it's reported that they
are not ejectable nor the have removable media. So the only
attribute that they have different from internal drives is that
they can be stopped.
So check for if the drive can be stopped to decide if it is
external or internal.
On the way realized we don't need to check for the mounts associated
with the volume to know if the volume can be ejected or not. So remove
that code.
https://bugzilla.gnome.org/show_bug.cgi?id=756589
|
| |
|
|
|
|
|
| |
Otherwise the "cursor" handle stays with "cursor" appearance instead of
"selection end" when a text selection is started.
|
|
|
|
| |
These long enums are used too often, shorten things a bit with temp vars.
|
|
|
|
|
|
|
|
| |
It is assumed that border.top is the same than pointing_to.height (which
equals the strong cursor position), which is not since some time ago.
The border calculation has been move on top too, it is now used in the
Y position one, and doesn't depend on anything we calculate later.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Text handles are subsurfaces on wayland, so sort of their own toplevel.
This made gtk_widget_translate_coordinates() to bail out there, resulting
in text handles being mispositioned and jumpy. To fix this, translate to
toplevel GtkWindow coordinates manually, and translate coordinates from
there.
Along the way, the coordinates reported in ::handle-dragged have been
fixed so there is no small jumps in either axis (most noticeable in the
X axis when you started dragging, and in the Y axis when moving between
lines of different heights.
|
|
|
|
|
|
|
| |
Some drives have removable media that is not ejectable (e.g. a laptop's
SD card reader). Show volumes on these drives in the sidebar.
https://bugzilla.gnome.org/show_bug.cgi?id=755654
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Make it what it is - the enum - so that that it is sure that the hint
will fit in the field. Without this, any hint that doesn't fit in 3
bits will be truncated to the 3 least significant bits, causing
unexpected behaviour.
https://bugzilla.gnome.org/show_bug.cgi?id=756496
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Using a NULL GAppInfo with g_app_launch_context_get_display() will
generate a critical warning in gio.
Use the display name instead as we don't have any valid GAppInfo to pass
to g_app_launch_context_get_display().
bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=756439
|
|
|
|
|
|
| |
Otherwise the popopver will be automatically unmapped in
_gtk_popover_update_child_visible() when the X axis (coming more
or less directly from events) goes outside the textview.
|
|
|
|
|
|
|
| |
There's nothing doing this explicitly, so tail position changes may
leave trails of older positions.
https://bugzilla.gnome.org/show_bug.cgi?id=756449
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GDK_NOTIFY_ANCESTOR would happen when the pointer crosses across a direct
parent/child. However nonlinear events are more likely, specially when
the pointer moves across toplevels (either different apps, or menus being
popped up over the pointer position).
This makes popping up comboboxes and other menus that fall over the pointer
position possible. With the previous detail the GtkMenu code misinterpreted
the crossing event, making it think the button release coming right after
should dismiss the popup, which made menus just flash on the screen unless
you kept the button pressed.
|
| |
|
|
|
|
|
|
|
|
| |
Use $(GlibEtcInstallRoot) when invoking glib-compile-schemas, as CopyDir
is not GlibInstallRoot for GTK+ (due to quoting issues), meaning that the
glib-compile-schemas tool may not be found in certain cases.
Issue pointed out by Ignacio Casal Quinteiro.
|
|
|
|
|
|
| |
A small utility binary to query all properties of GtkSettings.
https://bugzilla.gnome.org/show_bug.cgi?id=756174
|
|
|
|
|
|
|
| |
Otherwise, the validation may happen vey automatically some time during
the style property and that will most likely cause a crash.
https://bugzilla.gnome.org/show_bug.cgi?id=756338
|
| |
|
|
|
|
|
|
| |
we used to consider every button inside osd containers linked,
this is not true anymore, now those buttons behave normally.
This will clearly cause breakage in applications.
|
|
|
|
|
|
|
|
|
|
|
| |
According to http://datatracker.ietf.org/doc/rfc2911/, The 'name'
attribute syntax is essentially the same as 'text', including the
REQUIRED support of UTF-8 except that the sequence of characters
is limited so that its encoded form MUST NOT exceed 255 (MAX) octets.
CUPS will not print jobs with names exceeding 255 characters.
https://bugzilla.gnome.org/show_bug.cgi?id=755988
|
|
|
|
|
| |
Document that GtkIMContextSimple is loading additional compose
tables. Also document Ctrl-Shift-u.
|
|
|
|
|
|
|
| |
Load /usr/share/X11/locale/$LOCALE/Compose and $HOME/.XCompose
dynamically.
https://bugzilla.gnome.org/show_bug.cgi?id=721120
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=721120
|
|
|
|
|
|
| |
GtkComposeTable and GtkComposeTableCompact use guint16 for the data.
https://bugzilla.gnome.org/show_bug.cgi?id=721120
|
|
|
|
|
|
| |
Some functions need to be exported if X11 compose files are loaded.
https://bugzilla.gnome.org/show_bug.cgi?id=721120
|
| |
|
| |
|