| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
They use a GtkOverlay, so reflect that in the name.
|
|
|
|
|
|
|
| |
It was returning the full natural size (same as -1) due to default value
handling in the code below.
Tests have been updated to match this output.
|
|\
| |
| |
| |
| | |
textview: Provide more context to input methods
See merge request GNOME/gtk!4209
|
| |
| |
| |
| |
| |
| |
| |
| | |
When returning surrounding context to input methods,
include at least 2 words before and after the insertion
point.
Update the affected input method tests.
|
|/ |
|
|
|
|
|
|
| |
Natural size should never ellipsize.
Tests added.
|
|
|
|
|
|
|
| |
The download API is not well thought out yet, so postpone it until
there's an actual usecase for it.
Remove testcases, too.
|
| |
|
|
|
|
|
|
|
| |
Store the enum nick, not the enum value. That way the file remains
human-readable.
Updated reftests to new expected output.
|
|
|
|
|
|
| |
Testcase included
Fixes #4469
|
|
|
|
|
|
|
| |
Previously, the code did not expand the size properly when a default
size was already set.
Reftest included.
|
|
|
|
|
|
|
| |
This is a quickfix to avoid infinite runtime in nested boxes with
wrapped labels.
Test included
|
|
|
|
|
|
|
|
|
| |
If halign=fill, force adjustment to height-for-width.
If valign=fill, force adjustment to width-for-height.
Otherwise look at request mode.
This way we don't try to adapt the filled dimension and only adjust
the one that is not set to fill.
|
|
|
|
|
|
|
| |
This could lead to the wrong values being passed and computing invalid
sizes which would then lead to very unhappy code.
Test included.
|
|
|
|
|
|
|
| |
g_log_writer_standard_streams just puts all the logs
out onto stderr and stdout if we don't stop it. Pango
recently grew a bunch of g_debug calls, and those were
now showing up, making all the reftests fail.
|
|
|
|
|
| |
We use -Werror in the build, so even if some warnings are just warnings,
they'd be errors.
|
|
|
|
|
|
| |
Testcase included.
Fixes #4424
|
|
|
|
|
|
| |
This was broken in wrapping labels.
Testcase included.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Assume a vbox with 2 wrapping labels saying
Hello World
Hi Ho
being measured for their minimum width for 3 rows of text.
This should be layouted like
Hello
World
Hi Ho
and measured accordingly.
However, previously this was layouted as
Hello World
Hi Ho
with 1.5 lines being assigned to both labels.
That will obviously not compute the above wrapping which clearly
results in a smaller min width.
A reftest testing exactly this was included.
|
|
|
|
|
| |
When a widget is neither wrappable nor ellipsizable, we cannot modify
the label to fit into any size. So we cannot respect max-width-chars.
|
|
|
|
|
|
|
|
|
| |
Having a short text and a large max-width-chars should request the
natural width of the text, not the limit from max-width-chars.
This caused huge message dialogs.
Reftests added.
|
|
|
|
|
|
|
|
|
|
|
| |
Use a label that is long enough to require wrapping and force it into a
hardcoded width. Use a sentence where all the words have the same size
to not get unwanted wrapping behavior.
Also append a 2nd row to check that the first row gets the proper height
allocated.
Found by Marco Melorio.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For size -1 in the opposite orientation, GtkBoxLayout used to measure
the children based on their min size in the box's orientation instead of
-1. That wasn't really intended, but was a side effect of how the sizing
code did (not) distribute extra size above the minimum size.
This is clearly not what we want.
What we want is measuring the orientation as is for size -1. Then we
want to just take the maximum of all children and use that.
A reftest is incldued that ensures a vbox wraps a label just like an
hbox does.
|
|
|
|
|
|
|
|
|
|
| |
The old code couldn't properly do height-for-width because it only
computed the widest and smallest layout instead of looking at the actual
passed in for-size.
The label-sizing reftest has been adapted as the label code is now smart
enough to always display the whole text and no longer requests a too
small width-for-single-row when wrapping.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit ba44e7a228534ff066694ad97d25eaa23ec5f3af.
The change was meant to revert to old GTK3 behavior but it actually
broke new GTK4 behavior that is in use where max-width-chars is used to
determine an ideal size, but where we don't want to limit the width to
that size.
So what happens is the reintroduction of GTK3-style lots of whitepsace
bugs, and we really don't want those.
We also don't want to break backwards compat if we can avoid it.
So let's revert this.
The reftest that was made for this purpose has been adapted.
Fixes #4399
|
|
|
|
|
| |
Blinking cursors aren't helpful when we want to
compare renderings pixel-by-pixel. Turn them off.
|
|
|
|
| |
That environment variable isn't used anymore.
|
|
|
|
|
| |
The default-settings key works in non-debug builds
too, nowadays.
|
|
|
|
| |
The base_directory argument is never used. So don't have it.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a URL can't be loaded, we might end up with a NULL file. Handle that
case properly by creating an invalid image instead and don't crash or
complain to stderr when files are NULL.
This was broken since 0886ade182f1a958024202d5c20248d57fcdb053
A new reftest has been included. We need a reftest instead of a
CSS parser test, because the error only becomes visible when
compute()ing the actual image.
Fixes #4373
|
|\
| |
| |
| |
| |
| |
| | |
Add a bunch of reftests and fix their failures
Closes #4285
See merge request GNOME/gtk!4085
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Have square images in the following sizes:
* 20
* 100
* 150
* 200
* 300
and place them in a can-shrink Picture allocated at the sizes:
* 200x100
* 100x200
and set align to center/center.
That's 10 combinations and they should all do the right thing.
|
| |
| |
| |
| |
| |
| | |
If we have no node, don't crash when trying to save the node file.
Instead, write an empty file.
|
|/ |
|
|
|
|
| |
It's fixed now.
|
|
|
|
|
|
| |
label-sizing.ui tests this, too - but that test tests lots of other
things, and if this ever happens again, we want to debug it in a small
test.
|
|
|
|
|
| |
Doesn't hurt to have them available, so it's easy to figure out if a
failure is due to the renderer or if we're generating wrong node files.
|
|
|
|
| |
read: Fix tests for broadway
|
|
|
|
|
| |
Add unpremultiplied high-depth formats. They are used in the real world,
so let's support them.
|
|\
| |
| |
| |
| |
| |
| | |
Rename ngl to gl
Closes #4318
See merge request GNOME/gtk!4037
|
| |
| |
| |
| |
| | |
We have only one gl renderer now, and it is
a bit odd for it not be called gl.
|
| |
| |
| |
| |
| |
| |
| | |
This is supposed to test the most fallback GL stuff, so we might want to
set even more env vars here.
Also enable the run for the Fedora builder in CI.
|
| |
| |
| |
| |
| |
| |
| | |
Previously, all the tests used the icon upload path using
glTexSubImage2D().
This test uses the custom texture path using glTexImage2D().
|
|/
|
|
|
|
| |
Testcase included
Fixes #4324
|
|
|
|
|
| |
Don't run the full test and then return "something failed" - instead
just explode when you find the failure.
|
|\
| |
| |
| |
| | |
testsuite: Actually run all memorytexture tests
See merge request GNOME/gtk!4016
|
| |
| |
| |
| | |
Whoops
|
| |
| |
| |
| |
| |
| | |
Simplify enum properties as well.
Update affected tests.
|
| |
| |
| |
| |
| |
| | |
We can just set the css-classes property instead.
Update affected tests.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We were only applying <binding> elements when the
object is constructed, which can be triggered by
various things (e.g. a <style> element). Defer
this until we reach </object>, so we can be sure
that we pick up all the bindings.
Testcase included.
Fixes: #4147
|