summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRoss Lagerwall <rosslagerwall@gmail.com>2015-06-22 08:02:39 +0100
committerRoss Lagerwall <rosslagerwall@gmail.com>2015-08-06 07:11:51 +0100
commit5162da088e7fdcaa9993167e3071c1e40105546a (patch)
tree603696fcd762fb554bb3a65f1a48f1fa6caeb6ac
parentc758ab5dd62935ea6449fea683ee9280a53c5e38 (diff)
downloadgvfs-5162da088e7fdcaa9993167e3071c1e40105546a.tar.gz
udisks2: Handle libsecret error properly
secret_password_clear_finish() returns whether any passwords are removed, so it may return FALSE without setting error. Handle this properly (in this case all we care about is that there wasn't an error). https://bugzilla.gnome.org/show_bug.cgi?id=751038
-rw-r--r--monitor/udisks2/gvfsudisks2volume.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/monitor/udisks2/gvfsudisks2volume.c b/monitor/udisks2/gvfsudisks2volume.c
index 5e83c2c8..fac90e5c 100644
--- a/monitor/udisks2/gvfsudisks2volume.c
+++ b/monitor/udisks2/gvfsudisks2volume.c
@@ -1119,7 +1119,8 @@ luks_delete_passphrase_cb (GObject *source,
MountData *data = user_data;
GError *error = NULL;
- if (secret_password_clear_finish (result, &error))
+ secret_password_clear_finish (result, &error);
+ if (!error)
{
/* with the bad passphrase out of the way, try again */
g_free (data->passphrase);