summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexander Larsson <alexl@redhat.com>2009-11-19 11:53:10 +0100
committerAlexander Larsson <alexl@redhat.com>2009-11-19 11:59:29 +0100
commitea829d236ca2702ff52048dec86dc96b403e66d9 (patch)
treebf4323f7a50becca6449570d357e53a009f3f073
parent81e1695043422607da256f60c8bd306e6d14d33c (diff)
downloadgvfs-ea829d236ca2702ff52048dec86dc96b403e66d9.tar.gz
Don't store write() return val in unsigned variable
The conversion to unsigned means we failed to recognize errors, since if (ret < 0) was never hit. This is the suspected cause for data loss in bug 598561. (cherry picked from commit f45b677201abb6b8471fa5bc935afda420c28c39)
-rw-r--r--metadata/metabuilder.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/metadata/metabuilder.c b/metadata/metabuilder.c
index a4a2043c..a9060069 100644
--- a/metadata/metabuilder.c
+++ b/metadata/metabuilder.c
@@ -799,7 +799,7 @@ write_metadata (GString *out,
static gboolean
write_all_data_and_close (int fd, char *data, gsize len)
{
- gsize written;
+ gssize written;
gboolean res;
res = FALSE;