summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexander Larsson <alexl@redhat.com>2009-02-26 09:13:08 +0000
committerAlexander Larsson <alexl@src.gnome.org>2009-02-26 09:13:08 +0000
commit4f62230ac0fbfaa3e4da1bf37c5bdce34eb410d7 (patch)
tree4f30aa1ef79ff9bcd8bef094deb50c40b903e3b1
parent212fcb6681ffde3a186bf8ee2b71abd21686c5b4 (diff)
downloadgvfs-4f62230ac0fbfaa3e4da1bf37c5bdce34eb410d7.tar.gz
Fix order of SSH_FXP_SYMLINK arguments. It seems openssh is not following
2009-02-26 Alexander Larsson <alexl@redhat.com> * daemon/gvfsbackendsftp.c (try_make_symlink): Fix order of SSH_FXP_SYMLINK arguments. It seems openssh is not following the docs here. svn path=/trunk/; revision=2250
-rw-r--r--ChangeLog6
-rw-r--r--daemon/gvfsbackendsftp.c4
2 files changed, 9 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index 2e5daf56..e731821a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2009-02-26 Alexander Larsson <alexl@redhat.com>
+
+ * daemon/gvfsbackendsftp.c (try_make_symlink):
+ Fix order of SSH_FXP_SYMLINK arguments. It seems
+ openssh is not following the docs here.
+
2009-02-24 Paolo Borelli <pborelli@katamail.com>
* test/benchmark-posix-small-files.c:
diff --git a/daemon/gvfsbackendsftp.c b/daemon/gvfsbackendsftp.c
index d59c1418..3c8908b5 100644
--- a/daemon/gvfsbackendsftp.c
+++ b/daemon/gvfsbackendsftp.c
@@ -3833,8 +3833,10 @@ try_make_symlink (GVfsBackend *backend,
command = new_command_stream (op_backend,
SSH_FXP_SYMLINK);
- put_string (command, filename);
+ /* Note: This is the reverse order of how this is documented in
+ draft-ietf-secsh-filexfer-02.txt, but its how openssh does it. */
put_string (command, symlink_value);
+ put_string (command, filename);
queue_command_stream_and_free (op_backend, command, make_symlink_reply, G_VFS_JOB (job), NULL);