diff options
author | Ondrej Holy <oholy@redhat.com> | 2020-03-02 09:50:38 +0100 |
---|---|---|
committer | Ondrej Holy <oholy@redhat.com> | 2020-03-06 09:51:05 +0000 |
commit | 91f34aa87f6089c8d8437310854b83af3b6ba05b (patch) | |
tree | 09c3fa49a11daff378a6bb69fa2706e5efc05a7f | |
parent | bb10a52add73e1bdf801f77bdedb654e52ac98af (diff) | |
download | gvfs-91f34aa87f6089c8d8437310854b83af3b6ba05b.tar.gz |
udisks2: Fix leak when updating fstab volumes
`g_list_remove_link` is used when filtering out mountpoints, but the
GList element is not consequently freed. Let's use `g_list_delete_link`
to not leak that element.
https://gitlab.gnome.org/GNOME/gvfs/issues/452
-rw-r--r-- | monitor/udisks2/gvfsudisks2volumemonitor.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/monitor/udisks2/gvfsudisks2volumemonitor.c b/monitor/udisks2/gvfsudisks2volumemonitor.c index 37c81fcf..b200457d 100644 --- a/monitor/udisks2/gvfsudisks2volumemonitor.c +++ b/monitor/udisks2/gvfsudisks2volumemonitor.c @@ -1623,7 +1623,7 @@ update_fstab_volumes (GVfsUDisks2VolumeMonitor *monitor, have_udisks_volume_for_mount_point (monitor, mount_point) || !mount_point_has_device (monitor, mount_point)) { - new_mount_points = g_list_remove_link (new_mount_points, l); + new_mount_points = g_list_delete_link (new_mount_points, l); g_unix_mount_point_free (mount_point); } } |