diff options
| author | Ondrej Holy <oholy@redhat.com> | 2015-02-20 17:33:56 +0100 |
|---|---|---|
| committer | Ondrej Holy <oholy@redhat.com> | 2015-03-04 14:22:01 +0100 |
| commit | 56326e463a56afa0e632baad4c94faa7aa154486 (patch) | |
| tree | 288ac2358c63a26d23a3278b6af73da6531f8c75 /metadata | |
| parent | 8fdf64272ec47315cdd3e12d1aa628ad3bb837bc (diff) | |
| download | gvfs-56326e463a56afa0e632baad4c94faa7aa154486.tar.gz | |
metadata: return if meta_tree_refresh failed
G_UNLOCK is called twice if meta_tree_refresh fails and also concurrent
access is possible on cached_trees. However this isn't problem currently,
because meta_tree_lookup_by_name is always called with for_write=FALSE
(except for meta-set testing utility), so this if statement is never issued.
https://bugzilla.gnome.org/show_bug.cgi?id=598561
Diffstat (limited to 'metadata')
| -rw-r--r-- | metadata/metatree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/metadata/metatree.c b/metadata/metatree.c index 2983e5d5..0fe29a1b 100644 --- a/metadata/metatree.c +++ b/metadata/metatree.c @@ -547,7 +547,7 @@ meta_tree_lookup_by_name (const char *name, return tree; meta_tree_unref (tree); - tree = NULL; + return NULL; } filename = g_build_filename (g_get_user_data_dir (), "gvfs-metadata", name, NULL); |